Skip to content

Conversation

@vigneshTheDev
Copy link
Collaborator

No description provided.

@maxceem maxceem self-requested a review April 20, 2020 07:50
Copy link
Collaborator

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vigneshTheDev designs and code look great.

Just a couple of minor issues:

  1. At some tablet screen sizes, we already show labels for each input, but there are still labels in the table header too:

    image

    • as soon as we show labels per input, we can hide table header.
  2. I cannot copy and cannot paste using Command + C / Command + V from and to people and duration fields.

@vigneshTheDev
Copy link
Collaborator Author

vigneshTheDev commented Apr 21, 2020

Hi @maxceem, Issue # 1 is fixed.

For # 2, are you trying to copy paste non numbers?

@maxceem
Copy link
Collaborator

maxceem commented Apr 21, 2020

@vigneshTheDev I'm trying to copy/paste numbers.

Note, even if I try to copy from the field, it doesn't copy.

I think because I use key command and in the PR you are checking for ctrl (I think).

@vigneshTheDev
Copy link
Collaborator Author

@maxceem, yeah you're correct. Fixed it now. Can you please verify?

@maxceem maxceem self-requested a review April 21, 2020 17:22
@maxceem
Copy link
Collaborator

maxceem commented Apr 21, 2020

@vigneshTheDev from the quick test it works great now. I would recheck everything the final time tomorrow morning.

Copy link
Collaborator

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vigneshTheDev works great. Thank you.

@maxceem maxceem merged commit 97d9981 into topcoder-archive:dev Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants