enforce max values for people and duration in talent picker #3981
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxceem
requested changes
May 6, 2020
Collaborator
maxceem
left a comment
maxceem
left a comment
There was a problem hiding this comment.
@vigneshTheDev works good in most cases except if we increase number using arrows on the keyboard or in UI, see demo video. Is it possible to enforce this case too?
maxceem
reviewed
May 6, 2020
Collaborator
Author
Got it. I'll fix this issue. |
Collaborator
Author
|
Hi @maxceem, fixed the issue. Please review |
Positive number input
maxceem
approved these changes
May 7, 2020
Collaborator
maxceem
left a comment
maxceem
left a comment
There was a problem hiding this comment.
Grate solution, @vigneshTheDev works perfectly now!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.