Skip to content

feat: don't reload phases after adding #4155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vikasrohit merged 2 commits into from
Oct 26, 2020
Merged

feat: don't reload phases after adding #4155

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c3ad9a
feat: don't reload phases after adding
maxceem Oct 16, 2020
dec98a6
chore: clear unused action
maxceem Oct 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 3 additions & 15 deletions src/projects/detail/containers/ProjectAddPhaseContainer.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,6 @@ import { renderComponent, branch, compose, withProps } from 'recompose'
import spinnerWhileLoading from '../../../components/LoadingSpinner'
import { createProduct } from '../../actions/project'
import { getProductTemplateByKey } from '../../../helpers/templates'
import { loadProjectPhasesWithProducts } from '../../actions/project'
import { loadProjectDashboard } from '../../../projects/actions/projectDashboard'


import CoderBot from '../../../components/CoderBot/CoderBot'
import Wizard from '../../../components/Wizard'
Expand Down Expand Up @@ -91,26 +88,17 @@ class ProjectAddPhaseContainer extends React.Component {
window.location = returnUrl
} else {
if (isLoggedIn) {
this.props.history.push(`/projects/${project.id}/plan`)
this.props.history.push(`/projects/${project.id}`)
} else {
this.props.history.push('/')
// FIXME ideally we should push on router
// window.location = window.location.origin
}
}
}

componentWillReceiveProps(props) {
const project = _.get(props, 'project', null)
if (!props.processing && !props.error && project && this.state.isChosenProduct) {
if (this.state.shouldReloadPhases) {
// reload the project
props.loadProjectPhasesWithProducts(project.id)
this.setState({shouldReloadPhases: false})
} else if (!props.isLoadingPhases) {
// back to plan
this.closeWizard()
}
this.closeWizard()
}
}

Expand Down Expand Up @@ -165,6 +153,6 @@ const mapStateToProps = ({projectState, loadUser, templates, productsTimelines }
productCategories: templates.productCategories,
})

const actionCreators = {createProduct, loadProjectPhasesWithProducts, loadProjectDashboard}
const actionCreators = {createProduct}

export default withRouter(connect(mapStateToProps, actionCreators)(ProjectAddPhaseContainer))