Generic Phases with New Milestone Types #4221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generic Phases
- "Reporting" milestone type - "Deliverable Review" milestone type - "Final Deliverable Review" milestone type - "Deliverable Final Fixes" milestone type
Add New Milestone Types
fix: some issue and add milestone
…s-with-new-milestone-types # Conflicts: # src/projects/actions/productsTimelines.js # src/projects/detail/components/timeline/Milestone/Milestone.jsx
maxceem
changed the title
# Conflicts: # src/config/constants.js # src/projects/detail/containers/DashboardContainer.jsx
…-milestone-types fix: fixed generic phase issue
…-milestone-types fix: fix additional issues
…-milestone-types fix: change milestone.type to const type
also, moved default values to constants for reusing
There was issue, when we edit completed milestone, we update type from "value" to "title" of the type
ref issue #4203
There are 2 reasons for this: - customer don't have permissions to edit phases, so they cannot automatically mark phases as completed together with milestones - as per #4203 we have to use current date instead of actual status to show phase status, so we can remove this automatic status update ref issue #4203
- rename projectTemplate to productTemplate for phases&products - removed redundant code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.