Skip to content
This repository was archived by the owner on Jan 23, 2025. It is now read-only.

prevent tags from being deleted on design challenges #40

Merged
merged 3 commits into from
Dec 15, 2020
Merged

prevent tags from being deleted on design challenges #40

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cdc8580
prevent tags from being deleted on design challenges
ThomasKranitsas Dec 15, 2020
5cf33d9
fix
ThomasKranitsas Dec 15, 2020
ff0d131
fix
ThomasKranitsas Dec 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/services/syncService.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,12 @@ async function processChallenge (legacyId, challengeListing, challengeDetails) {
logger.error(`Sync :: Failed to load submissions for challenge ${legacyId}`)
logger.logFullError(e)
}

const ommittedFields = ['id', 'type', 'track', 'typeId', 'trackId', 'prizeSets', 'descriptionFormat']

// logger.info(`After V5 Sub Sync: ${challengeObj.numOfSubmissions} ${v5ChallengeFromAPI.numOfSubmissions}`)
if (v5ChallengeObjectFromV4.track.toUpperCase() === V4_TRACKS.DESIGN) {
ommittedFields.push('tags')
try {
const submissions = await challengeService.getChallengeSubmissionsFromV5API(legacyId, config.CHECKPOINT_SUBMISSION_TYPE)
additionalInformation.numOfCheckpointSubmissions = _.toNumber(submissions.total) || 0
Expand All @@ -80,8 +84,6 @@ async function processChallenge (legacyId, challengeListing, challengeDetails) {
}
}

const ommittedFields = ['id', 'type', 'track', 'typeId', 'trackId', 'prizeSets', 'descriptionFormat']

if (v5ChallengeFromAPI.descriptionFormat !== 'HTML') {
ommittedFields.push('description')
ommittedFields.push('privateDescription')
Expand Down