Skip to content
This repository was archived by the owner on Mar 13, 2025. It is now read-only.

[$80] Subcommunities should be all selected #78

Open
Oanh-and-only-Oanh opened this issue Apr 22, 2021 · 37 comments
Open

[$80] Subcommunities should be all selected #78

Oanh-and-only-Oanh opened this issue Apr 22, 2021 · 37 comments

Comments

@Oanh-and-only-Oanh
Copy link

Oanh-and-only-Oanh commented Apr 22, 2021

Describe Bug: "Open of Registration challenges" is selected but the subcommunitiies are all unselected. See below.

Expected behavior: All Subcommunities should be selected when " "Open of Registration challenges" is selected.

image

@luizrrodrigues luizrrodrigues changed the title Subcommunities should be all selected [$80] Subcommunities should be all selected Apr 23, 2021
@luizrrodrigues
Copy link
Collaborator

important: When all sub communities are selected, not need call endpoint with sub-communities filter.

@luizrrodrigues
Copy link
Collaborator

Challenge https://www.topcoder.com/challenges/71d534a8-a6e3-4c18-944a-783516666e0e has been created for this ticket.

This is an automated message for luizrrodrigues via Topcoder X

@nursoltan-s
Copy link

@bug-bash-helper assign me

@bug-bash-helper
Copy link

@nursoltan-s ✅ you are now assigned to this issue and have 12 hours to complete it.

As soon as you are done, please, make a comment like below, including the link to the pull request:

@bug-bash-helper <link to PR> is ready for review

@luizrrodrigues
Copy link
Collaborator

Challenge https://www.topcoder.com/challenges/71d534a8-a6e3-4c18-944a-783516666e0e has been assigned to nursoltan-s.

This is an automated message for luizrrodrigues via Topcoder X

@nursoltan-s
Copy link

@bug-bash-helper unassign me

@bug-bash-helper
Copy link

@nursoltan-s ✅ you have been unassigned from this issue.

Now you may pick up another issue which is open for pickup if you like to.

@luizrrodrigues
Copy link
Collaborator

Challenge https://www.topcoder.com/challenges/71d534a8-a6e3-4c18-944a-783516666e0e nursoltan-s has been unassigned.

This is an automated message for luizrrodrigues via Topcoder X

@ganganimaulik
Copy link

@bug-bash-helper assign me

@bug-bash-helper
Copy link

@ganganimaulik ✅ you are now assigned to this issue and have 12 hours to complete it.

As soon as you are done, please, make a comment like below, including the link to the pull request:

@bug-bash-helper <link to PR> is ready for review

@luizrrodrigues
Copy link
Collaborator

@ganganimaulik, please sign-up with Topcoder X tool

This is an automated message for luizrrodrigues via Topcoder X

@ganganimaulik
Copy link

ganganimaulik commented Apr 27, 2021

@ganganimaulik, please sign-up with Topcoder X tool

This is an automated message for luizrrodrigues via Topcoder X

Capture

cant login for my email

@codingdrone
Copy link

is it open?

@luizrrodrigues
Copy link
Collaborator

@ganganimaulik hey. Are you working on this?

@luizrrodrigues
Copy link
Collaborator

@lightmare
Copy link

@bug-bash-helper assign me

@bug-bash-helper
Copy link

@lightmare ✅ you are now assigned to this issue and have 12 hours to complete it.

As soon as you are done, please, make a comment like below, including the link to the pull request:

@bug-bash-helper <link to PR> is ready for review

@luizrrodrigues
Copy link
Collaborator

Challenge https://www.topcoder.com/challenges/71d534a8-a6e3-4c18-944a-783516666e0e has been assigned to lightmare.

This is an automated message for luizrrodrigues via Topcoder X

@lightmare
Copy link

@bug-bash-helper #89 is ready for review

@bug-bash-helper
Copy link

@lightmare ✅ this issue is marked as Ready for Review.

Now you may pick up another issue which is open for pickup if you like to.

@luizrrodrigues
Copy link
Collaborator

@lightmare Your solution break other filters, check feedback in PR.

@luizrrodrigues luizrrodrigues modified the milestones: v1.0, v1.1 May 3, 2021
@lightmare
Copy link

@bug-bash-helper #89 is ready for review

@bug-bash-helper
Copy link

@lightmare ✅ this issue is marked as Ready for Review.

Now you may pick up another issue which is open for pickup if you like to.

@sushilshinde
Copy link
Contributor

@luizrrodrigues what's the status on this one?

@luizrrodrigues
Copy link
Collaborator

@lightmare If unselected all sub-communities, all sub-communities are selected, expect latest one unselect. From this point, filter will looks break if not selected this item.

https://i.gyazo.com/a243d01d5f9a897209ba39d204de7670.mp4

@lightmare
Copy link

That looks like a bug in the checkbox component to me. All the other checkboxes switch on when the filter becomes empty, only the last one remains unchecked.

I've pushed a fix that forces checkbox to refresh its state after onChange. Not sure that's the best way to do it, but it avoids getting stuck in the wrong state.

@Oanh-and-only-Oanh
Copy link
Author

@luizrrodrigues, please hold on this. We are changing design on this. FYI @sushilshinde and @SathyaJayabal.

@SathyaJayabal SathyaJayabal removed this from the v1.0.2 milestone Jul 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

8 participants