Skip to content
This repository was archived by the owner on Mar 13, 2025. It is now read-only.

[$100] Duplicate webhooks registered #432

Closed
jmgasper opened this issue Sep 8, 2021 · 5 comments
Closed

[$100] Duplicate webhooks registered #432

jmgasper opened this issue Sep 8, 2021 · 5 comments

Comments

@jmgasper
Copy link
Collaborator

jmgasper commented Sep 8, 2021

@afrisalyp - I added a second repo (comma-delimited) to and existing project in Topcoder-X, and then hit the webhook button to add the webhook to the newly added repo, but it also added a duplicate to the existing repo, so I ended up creating a couple duplicate payments since there were events processed twice. Can we add a check to make sure we don't add duplicate webhooks please?

Screen Shot 2021-09-09 at 6 39 58 am

Screen Shot 2021-09-09 at 7 03 33 am

@jmgasper
Copy link
Collaborator Author

jmgasper commented Sep 8, 2021

Challenge https://www.topcoder.com/challenges/2c46b476-9e48-42e0-95ee-cf8dd50fb61c has been created for this ticket.

This is an automated message for ghostar2020 via Topcoder X

@jmgasper
Copy link
Collaborator Author

jmgasper commented Sep 9, 2021

Challenge https://www.topcoder.com/challenges/2c46b476-9e48-42e0-95ee-cf8dd50fb61c has been assigned to afrisalyp.

This is an automated message for ghostar2020 via Topcoder X

@afrisalyp
Copy link
Collaborator

@jmgasper

Sorry for the problem. We have handled such issues to prevent duplicate webhooks, but it seems the mechanism was broken when we update a project (adding new or removing a repo URL).

Fixed in the latest pull request.

jmgasper added a commit that referenced this issue Sep 9, 2021
#432 fix registeredWebhookId missing in the update project function.
@jmgasper
Copy link
Collaborator Author

jmgasper commented Sep 9, 2021

@afrisalyp - No worries, thanks for the quick turnaround!

@jmgasper
Copy link
Collaborator Author

jmgasper commented Sep 9, 2021

Payment task has been updated: https://www.topcoder.com/challenges/2c46b476-9e48-42e0-95ee-cf8dd50fb61c
Payments Complete
Winner: afrisalyp
Copilot: ghostar2020
Challenge 2c46b476-9e48-42e0-95ee-cf8dd50fb61c has been paid and closed.

This is an automated message for ghostar2020 via Topcoder X

@jmgasper jmgasper added this to the Version 1.2.1 milestone Sep 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants