Skip to content
This repository was archived by the owner on Mar 13, 2025. It is now read-only.

[$150] clicking on edit sign cant see full page #17

Closed
akultalwar89-zz opened this issue Jul 12, 2020 · 30 comments
Closed

[$150] clicking on edit sign cant see full page #17

akultalwar89-zz opened this issue Jul 12, 2020 · 30 comments
Assignees
Labels
bug Something isn't working medium priority Not a roadblock to release but must be addressed at some point tcx_Assigned tcx_FixAccepted tcx_Paid

Comments

@akultalwar89-zz
Copy link

Steps to reproduce
• 1. Go to application-https://crm-benefits-prototype.herokuapp.com/pharmacy
• 2. Ncicking on edit sign - cant see full page

Current results
-cicking onedit sign - cant see full page

Expected results

  • user should be able to see full page

    Browser version: Chrome: Version 83.0.4103.116
    OS version : Macbook Air , Catalina 10.15.2
    Screen shots


Screen Shot 2020-07-12 at 6 35 44 PM

@akultalwar89-zz
Copy link
Author

Name is not seen properly at the top - cutting

@akultalwar89-zz
Copy link
Author

Please update step 1 website link to - https://skill-search.topcoder-dev.com/

@callmekatootie
Copy link
Collaborator

@akultalwar89 Can you kindly let me know the resolution of your screen when you faced the issue

@akultalwar89-zz
Copy link
Author

@callmekatootie - Its 1280 X 800 - i have been working on this - Macbook air 13 inch
It seens to be working fine on all the applications , here it got stuck

@callmekatootie
Copy link
Collaborator

@wdprice What resolution are we expected to support

This was referenced Jul 15, 2020
@callmekatootie
Copy link
Collaborator

Ignore earlier query. Checked in my laptop with 1920x1080 resolution and can indeed find the edit modal to be too big to fit in the screen.

@callmekatootie
Copy link
Collaborator

Thanks for the update.

Yep. I agree that this one needs more effort. You can take time on it.

@narekcat
Copy link
Contributor

@callmekatootie . Ok, thank you.

@narekcat narekcat mentioned this issue Jul 24, 2020
@narekcat
Copy link
Contributor

@callmekatootie . I have fixed this issue. Please see pull request #578.

@callmekatootie
Copy link
Collaborator

Bumping the payment on this ticket to by $50 @narekcat based on the effort involved

@callmekatootie callmekatootie changed the title [$100] clicking on edit sign cant see full page [$150] clicking on edit sign cant see full page Jul 25, 2020
@narekcat
Copy link
Contributor

@callmekatootie Thank you.

@callmekatootie
Copy link
Collaborator

@narekcat I have accepted the PR but there's one issue in Firefox.

In the edit profile modal, when you search for a skill, the dropdown is not shown properly

image

Expected:

image

I am shortly going to review in IE11 as well and will share my feedback here

@narekcat
Copy link
Contributor

@callmekatootie Ok, I'll fix this issue too.

@callmekatootie
Copy link
Collaborator

@narekcat On IE11 it is definitely much much better.

Found just one issue in IE11:

image

The role and company seems to overlap with the groups - expected would be that the role / company push the group content further down (I would say that it can squish group up to the extent where at a minimum 2 groups can be visible - that much height I mean - the groups can have)

@narekcat
Copy link
Contributor

@callmekatootie Ok, I'll fix this issue too.

@narekcat
Copy link
Contributor

Hello @callmekatootie . I have tested Firefox in my local machine, but skill's drop-down shows correctly. See screenshot:
image

And I have fixed issue with IE11 overflow. Please see pull request #607.

@callmekatootie
Copy link
Collaborator

I can not reproduce it consistently too - I can reproduce it occasionally but not frequent enough to be significant I would say. So no worries

@narekcat
Copy link
Contributor

@callmekatootie Okay.

@cwdcwd
Copy link
Contributor

cwdcwd commented Jul 26, 2020

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30133957

This is an automated message for lazybaer via Topcoder X

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working medium priority Not a roadblock to release but must be addressed at some point tcx_Assigned tcx_FixAccepted tcx_Paid
Projects
None yet
Development

No branches or pull requests

5 participants