Skip to content
This repository was archived by the owner on Mar 13, 2025. It is now read-only.

changes for #116 #576

Merged
merged 2 commits into from
Jul 24, 2020
Merged

changes for #116 #576

merged 2 commits into from
Jul 24, 2020

Conversation

phongnt
Copy link
Collaborator

@phongnt phongnt commented Jul 24, 2020

@phongnt phongnt requested a review from callmekatootie July 24, 2020 13:14
@callmekatootie
Copy link
Collaborator

@phongnt A better solution would be to check for existence of error.response.data.message itself and display if it exists... That way, we don't have to worry about the http status codes (say, in the future, a new error is raised with a different http status code - in which case, your solution won't work)

@callmekatootie callmekatootie merged commit 6cf9adb into develop Jul 24, 2020
@callmekatootie callmekatootie deleted the issue-116 branch July 24, 2020 14:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants