Prod: read BA from the v5 APi #388
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vikasrohit
reviewed
Feb 25, 2021
src/services/ChallengeService.js
Outdated
| @@ -1209,7 +1209,7 @@ async function update (currentUser, challengeId, data, isFull) { | |||
| if (!_.get(challenge, 'legacy.pureV5Task') && _.isUndefined(_.get(challenge, 'legacy.directProjectId'))) { | |||
There was a problem hiding this comment.
@ThomasKranitsas @rootelement should we now validate the projectId ( it might not be needed at all) instead of legacy.directProjectId?
There was a problem hiding this comment.
The legacy.directProjectId is used to see if the challenge was created on legacy. We now use the projectId property to get the billing account information
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.