Skip to content

[$50]Marathon Matches details not shown to the user #2359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
m-yadav opened this issue May 16, 2019 · 34 comments
Closed

[$50]Marathon Matches details not shown to the user #2359

m-yadav opened this issue May 16, 2019 · 34 comments
Labels
P1 Urgent (resolve within 24 hours) tcx_ReadyForReview

Comments

@m-yadav
Copy link

m-yadav commented May 16, 2019

Details page for marathon challenges is not working for users. Its giving error "ailed to get member marathons".

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'https://www.topcoder.com/members/</InsertHandle/>/details/?track=DATA_SCIENCE&subTrack=MARATHON_MATCH&tab=statistics'
  2. You ll be able to see the records along with the chart for rating.
  3. Click on challenges will take you to the next page which can be accessed directly by link "https://www.topcoder.com/members/</InsertHandle/>/details/?track=DATA_SCIENCE&subTrack=MARATHON_MATCH&tab=challenges" as well
  4. You ll be able to see below error
    image

Console throws below error

image

Expected behavior
Challenge details pertaining to marathon matches should be shown to the user.

@sushilshinde
Copy link
Collaborator

sushilshinde commented May 31, 2019

@m-yadav any handle example with lot of MMs?

@sushilshinde sushilshinde added the P1 Urgent (resolve within 24 hours) label May 31, 2019
@Ardavel
Copy link

Ardavel commented May 31, 2019

I have reported the issue for my handle: "Ardavel". However, I've participated only in two MMs.

@sushilshinde
Copy link
Collaborator

@skyhit please have a look

@skyhit
Copy link
Contributor

skyhit commented Jun 3, 2019

@sushilshinde check https://api.topcoder.com/v4/members/ardavel/mms/?filter=status%3DPAST%26isRatedForMM%3Dtrue&orderBy=endDate%20desc&limit=36&offset=0, it returns

{"id":"-7151b0f2:16b1b2cdf7e:-2fe2","result":{"success":true,"status":500,"metadata":null,"content":"{\"root_cause\":[{\"type\":\"index_not_found_exception\",\"reason\":\"no such index\",\"resource.type\":\"index_or_alias\",\"resource.id\":\"mmatches3\",\"index\":\"mmatches3\"}],\"type\":\"index_not_found_exception\",\"reason\":\"no such index\",\"resource.type\":\"index_or_alias\",\"resource.id\":\"mmatches3\",\"index\":\"mmatches3\"}"},"version":"v3"}

long time ago, we used a separate indexes for marathon matches and srms matches, for now, I think we should members/ardavel/challenges instead of members/ardavel/mms/

what do you think?

or you want to change in api side

@sushilshinde
Copy link
Collaborator

@skyhit please go ahead, I'll link issues

@skyhit
Copy link
Contributor

skyhit commented Jun 6, 2019

@sushilshinde change in api side, or directly use member//challenges, I think we should drop the usage of members/ardavel/mms/

@sushilshinde
Copy link
Collaborator

@sushilshinde sushilshinde changed the title Marathon Matches details not shown to the user [$50]Marathon Matches details not shown to the user Jun 6, 2019
@ThomasKranitsas
Copy link
Contributor

Contest https://www.topcoder.com/challenges/30092667 has been created for this ticket.

This is an automated message for thomaskranitsas via Topcoder X

@ThomasKranitsas
Copy link
Contributor

Contest https://www.topcoder.com/challenges/30092667 has been updated - the new changes has been updated for this ticket.

This is an automated message for thomaskranitsas via Topcoder X

@sushilshinde
Copy link
Collaborator

sushilshinde commented Jun 6, 2019

The current call is failing to pull past marathon matches because endpoint and filter params are outdated. This fix is to update endpoint and filter params to include PAST Marathon matches in the community app. Past marathon matches are of two types (on system level, users do not care)

1. MARATHON_MATCH
2. DEVELOP_MARATHON_MATCH

GET call :

https://api.topcoder.com/v4/members/ardavel/challenges/?filter=status%3DCOMPLETED%26subTrack%3DMARATHON_MATCH,DEVELOP_MARATHON_MATCH&limit=36&offset=0

Please do adjust the data model read the code in case JSON structure is different.

@topcoder-platform/topcodercompetitors this is open for pickup.

PR on hot-fixes-3 branch.

@ThomasKranitsas
Copy link
Contributor

Contest https://www.topcoder.com/challenges/30092667 has been updated - it has been assigned to rashmi73.

This is an automated message for thomaskranitsas via Topcoder X

@rashmi73
Copy link
Contributor

rashmi73 commented Jun 6, 2019

@sushilshinde is it just front end change?

@sushilshinde
Copy link
Collaborator

@rashmi73 yes, it is P1 and urgent

@rashmi73
Copy link
Contributor

rashmi73 commented Jun 6, 2019

@sushilshinde PR has been raised at both repos.
Primary change is at topcoder-react-lib to change param and url.

currently at develop branch PR has been raised

and here PR is raised on hot-fixes-3 for minor model change.

#2417
topcoder-platform/topcoder-react-lib#70

@sushilshinde
Copy link
Collaborator

@rashmi73 thanks. Deployment pipeline has been a little busy, so it's taking time.

@harshitmehta15
Copy link

Hey @sushilshinde has this been deployed? :)

@rashmi73
Copy link
Contributor

@sushilshinde any updates on this? I do not wish to lose my efforts.

@rashmi73
Copy link
Contributor

@sushilshinde waiting here

@rashmi73
Copy link
Contributor

@harshitmehta123 @ThomasKranitsas @nithyaasworld @sushilshinde can anyone atleast please respond?

@rashmi73
Copy link
Contributor

@harshitmehta123 @ThomasKranitsas @nithyaasworld @sushilshinde some reply would be really helpful from anybody. keeping aside other tasks this task was taken at priority and completed to best.but then it disappoints that no one is ready to reply anything whether this task is ignored? it will be merged later? PR is not proper?

efforts are wasted? I am in real need of money hence it is a discouragement to see efforts go wasted like this and no one responds being a P1 task.

@sushilshinde
Copy link
Collaborator

Your efforts will not be wasted that I can guarranty you. This do not happen often I apologize for this one but there are/were some other internal priorities, so everybody is busy with that.

I can't attend this right away, but this is on my list.

@rashmi73
Copy link
Contributor

@sushilshinde thanks for the response, Yes I see there are many Accesiblity issues open/reviewed and merged, till then waiting no problem. I just wanted to bring it your notice that this issue is pending, as you commented so I am assured now. thanks

@cwdcwd
Copy link
Contributor

cwdcwd commented Jul 25, 2019

[500]: Challenge for the updated issue 2359 is creating, rescheduling this event

This is an automated message for lazybaer via Topcoder X

1 similar comment
@cwdcwd
Copy link
Contributor

cwdcwd commented Jul 25, 2019

[500]: Challenge for the updated issue 2359 is creating, rescheduling this event

This is an automated message for lazybaer via Topcoder X

@cwdcwd
Copy link
Contributor

cwdcwd commented Jul 25, 2019

[504]: Failed to create challenge.

This is an automated message for lazybaer via Topcoder X

1 similar comment
@cwdcwd
Copy link
Contributor

cwdcwd commented Jul 25, 2019

[504]: Failed to create challenge.

This is an automated message for lazybaer via Topcoder X

@cwdcwd
Copy link
Contributor

cwdcwd commented Jul 25, 2019

Contest https://www.topcoder.com/challenges/30097469 has been created for this ticket.

This is an automated message for lazybaer via Topcoder X

@jmgasper jmgasper assigned rashmi73 and unassigned rashmi73 Jul 25, 2019
@cwdcwd
Copy link
Contributor

cwdcwd commented Jul 25, 2019

Contest https://www.topcoder.com/challenges/30097469 has been updated - it has been assigned to rashmi73.

This is an automated message for lazybaer via Topcoder X

@rashmi73
Copy link
Contributor

@sushilshinde any updates on this?

@rashmi73
Copy link
Contributor

@sushilshinde can I get anything on this? thank you

@mcskinner
Copy link

@cwdcwd @crazyk07 @sushilshinde @rashmi73 it looks like this one fell through the cracks.

The contest to fix this has, theoretically, been live since July. But since @rashmi73 is here asking for more help, I suspect that the contest was not as "live" or set up as it needed to be.

@cwdcwd
Copy link
Contributor

cwdcwd commented Jan 16, 2020

@mcskinner that's a placeholder for the task payment and it looks like this ticket has been languishing. @sushilshinde can we pick this one back up?

@crazyk07
Copy link

This ticket was not processed for payment. If you would like to process it for payment, please reopen it, add the tcx_FixAccepted label, and then close it again

This is an automated message for crazyk via Topcoder X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 Urgent (resolve within 24 hours) tcx_ReadyForReview
Projects
None yet
Development

No branches or pull requests