Skip to content

Abandonment Ad Code added to gig pages. #4912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
hokienick opened this issue Sep 14, 2020 · 6 comments
Closed

Abandonment Ad Code added to gig pages. #4912

hokienick opened this issue Sep 14, 2020 · 6 comments
Assignees
@kkartunov
Labels
Gig Work P1 Urgent (resolve within 24 hours) QA Pass in PROD Passed verification on Production
Milestone
v1.2.1

Comments

@hokienick
Copy link

Add code snippet to gig listings and gig description pages.
@Oanh-and-only-Oanh
Copy link

@luizrrodrigues, please do a hot fix release for this ticket for this Wednesday. It will be a release for this just. @kkartunov is working on the ticket but please have it ready for QA by Tuesday India morning time for @SathyaJayabal to verify.

@Oanh-and-only-Oanh Oanh-and-only-Oanh added this to the 09/16/2020 milestone Sep 14, 2020
@kkartunov kkartunov added the P1 Urgent (resolve within 24 hours) label Sep 14, 2020
kkartunov added a commit that referenced this issue Sep 14, 2020
@kkartunov
Implements #4912
ed0044a
luizrrodrigues added a commit that referenced this issue Sep 15, 2020
@luizrrodrigues
ci: Deploy hot-fix-ad-code to Test env
43786c4 
Issue; #4912
@SathyaJayabal
Copy link
Collaborator

SathyaJayabal commented Sep 15, 2020 •
edited
Loading

verified on test, tracking code present in header for gigs listings and gigs details pages.
Screenshot 2020-09-15 at 9 07 49 AM
Screenshot 2020-09-15 at 9 08 34 AM

@kkartunov , I see the code snippet added to all the pages. Is this intentional ?

cc @hokienick

@SathyaJayabal SathyaJayabal added Need clarification Need clarification to proceed fixing the issue further and removed Ready for QA labels Sep 15, 2020
@kkartunov
Copy link
Collaborator

@SathyaJayabal yep, it should be on all pages.

@SathyaJayabal
Copy link
Collaborator

@kkartunov ,thanks

@SathyaJayabal SathyaJayabal added QA Pass and removed Need clarification Need clarification to proceed fixing the issue further labels Sep 15, 2020
@SathyaJayabal SathyaJayabal modified the milestones: 09/16/2020, v1.2.1 Sep 15, 2020
luizrrodrigues added a commit that referenced this issue Sep 15, 2020
@luizrrodrigues
Merge pull request #4914 from topcoder-platform/hot-fix-ad-code
20c22d4 
Implements #4912
@SathyaJayabal
Copy link
Collaborator

verified on staging(develop)
Screenshot 2020-09-15 at 11 27 52 AM

@luizrrodrigues luizrrodrigues mentioned this issue Sep 15, 2020
Merged
sushilshinde added a commit that referenced this issue Sep 15, 2020
@sushilshinde
release: v1.2.1
27118ee 
Title: Bug-fixes : v5 integration, cotentful, etc( Release - v1.2.1) (sushil)
Service & Impact Area: Community App
Expected Outcome: Fixes for MS https://github.com/topcoder-platform/community-app/milestone/55
Work plan: Issues: #2069 #4874 #4898 #4347 #4745 #4895 #4687 #4910 #4896 #4889 #4888 #4887 #4912
PR: #4923
DEPENDENCY: topcoder-react-lib
- Issue: #2069
- PR: topcoder-platform/topcoder-react-lib#253
DEPENDENCY: topcoder-react-ui-kit
- Issue: #4745
- PR: topcoder-archive/topcoder-platform-topcoder-react-ui-kit#35
Team: luiz/picachui/sandhiya/kiril/sushil
Date and Timing: Tue 15 Sept 2020, 4.00 PM
Testing (what will be tested): Fixes for MS https://github.com/topcoder-platform/community-app/milestone/55
Rollback Plan: Revert PR
@SathyaJayabal SathyaJayabal added QA Pass in PROD Passed verification on Production and removed QA Pass in Staging labels Sep 15, 2020
@SathyaJayabal
Copy link
Collaborator

verified on prod
Screenshot 2020-09-15 at 4 25 41 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kkartunov kkartunov

Labels
Gig Work P1 Urgent (resolve within 24 hours) QA Pass in PROD Passed verification on Production
Projects
None yet
Milestone
v1.2.1
Development

No branches or pull requests
5 participants
@hokienick @kkartunov @luizrrodrigues @Oanh-and-only-Oanh @SathyaJayabal