Skip to content

#101 fixed bug for "more" tab swapping position #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 17, 2020

Conversation

yoution
Copy link
Contributor

@yoution yoution commented Jan 14, 2020

No description provided.

Copy link
Collaborator

@luizrrodrigues luizrrodrigues left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check: #101 (comment)

@luizrrodrigues
Copy link
Collaborator

@yoution This was fixed?

@yoution
Copy link
Contributor Author

yoution commented Jan 15, 2020

@luizrrodrigues https://monosnap.com/file/NdOOaVDmxE1PKvQ72PmKs4rovMiXtA
still has problem in your computer?

@luizrrodrigues
Copy link
Collaborator

@yoution Not reviewed yet, just confirming. :)

@luizrrodrigues luizrrodrigues merged commit 57dcba6 into topcoder-platform:nav-bugbash-2 Jan 17, 2020
@luizrrodrigues
Copy link
Collaborator

@yoution I found an issue when "more" not showing.

Compete is moving the position in menu, check:

Screen Recording 2020-01-17 at 21.06.40.mov.zip

@yoution
Copy link
Contributor Author

yoution commented Jan 18, 2020

@luizrrodrigues to reproduce the problem , I want to show the more button, but it not show, I have make the screen very narrow, https://monosnap.com/file/Zx2vQMSpasW0oWZSYs71dsQa47ttSa

@luizrrodrigues
Copy link
Collaborator

@yoution I see, I'm able to see the "more" button.

What I'm mean is about when "more" button not showing the "compete" menu item is moving, this need be fixed.

@yoution
Copy link
Contributor Author

yoution commented Jan 18, 2020

@luizrrodrigues #128 please review again

@yoution
Copy link
Contributor Author

yoution commented Jan 18, 2020

@luizrrodrigues I don't know, the 'more' button is not showed, even the screen is very narrow

@luizrrodrigues
Copy link
Collaborator

@yoution Ah okay, you mean in your side no able to see "more" button?

Have you try use Firefox?

@yoution
Copy link
Contributor Author

yoution commented Jan 18, 2020

@luizrrodrigues firefox always show the 'more' button, chrome can not show the 'more' button even the screen is very narrow, I have pushed, please review

@luizrrodrigues
Copy link
Collaborator

@yoution Okay, I'll review and let you know. We already have a ticket to fix "more" always showing in Firefox.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants