Skip to content

fix issue #132 #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: nav-bugbash-2
Choose a base branch
from
Open

fix issue #132 #122

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
60e13ca
fix issue 2504
LieutenantRoger Jan 15, 2020
64008e4
fix enter key issue
LieutenantRoger Jan 21, 2020
33e02fa
Merge branch 'nav-bugbash-2' into Issue2504
luizrrodrigues Jan 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/LoginNav/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ const LoginNav = ({
}

return (
<div className={styles.loginContainer}>
<div tabIndex='0' className={styles.loginContainer}>
{loggedIn ? renderLoginPanel() : (
<a
href='javascript:void(0)'
Expand Down
4 changes: 4 additions & 0 deletions src/components/TopNav/PrimaryNav.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ const PrimaryNav = ({
<div className={cn(styles.primaryNavContainer, showLeftMenu && styles.primaryNavContainerOpen)}>
<div className={styles.primaryNav} ref={createSetRef('primaryNav')}>
<a
tabIndex='0'
className={cn(styles.tcLogo, collapsed && styles.tcLogoPush)}
onClick={onClickLogo}
href='/'
Expand All @@ -54,6 +55,7 @@ const PrimaryNav = ({
<span className={styles.primaryLevel1Separator} key={`separator-${i}`} />,
/* Level 1 menu item */
<a
tabIndex='0'
className={cn(styles.primaryLevel1, !activeLevel2Id && level1.id === activeLevel1Id && styles.primaryLevel1Open, level1.mobileOnly && styles.mobileOnly)}
href={level1.href}
key={`level1-${i}`}
Expand All @@ -71,6 +73,7 @@ const PrimaryNav = ({
>
{level1.subMenu.filter(filterNotInMore).map((level2, i) => (
<a
tabIndex='0'
className={cn(styles.primaryLevel2, level2.id === activeLevel2Id && styles.primaryLevel2Open)}
href={level2.href}
key={`level2-${i}`}
Expand All @@ -97,6 +100,7 @@ const PrimaryNav = ({
<div className={styles.moreContentContainer}>
{moreMenu.map((menu, i) => (
<a
tabIndex='0'
className={cn(styles.primaryLevel2, menu.id === activeLevel2Id && styles.primaryLevel2Open)}
href={menu.href}
key={`more-item-${i}`}
Expand Down