Skip to content

Fix unapprove challenge id #1073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Dispatch, FC, SetStateAction, useMemo, useState } from 'react'
import { Dispatch, FC, SetStateAction, useEffect, useMemo, useState } from 'react'
import { NavigateFunction, useLocation, useNavigate } from 'react-router-dom'

import { TabsNavbar } from '~/libs/ui'
Expand All @@ -24,6 +24,14 @@ const SystemAdminTabs: FC = () => {
navigate(childTabId)
}

// If url is changed by navigator on different tabs, we need set activeTab
useEffect(() => {
const pathTabId = getTabIdFromPathName(pathname)
if (pathTabId !== activeTab) {
setActiveTab(pathTabId)
}
}, [pathname]) // eslint-disable-line react-hooks/exhaustive-deps

return (
<div className={styles.container}>
<TabsNavbar
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ import {
} from '../../lib/models'
import {
approveApplication,
getChallengeByLegacyId,
getChallengeReviewers,
getChallengeReviewOpportunities,
rejectPending,
Expand Down Expand Up @@ -61,6 +62,7 @@ export const ManageReviewerPage: FC = () => {
const { challengeId = '' }: { challengeId?: string } = useParams<{
challengeId: string
}>()
const [challengeUuid, setChallengeUuid] = useState('')
const navigate: NavigateFunction = useNavigate()
const [filterCriteria, setFilterCriteria]: [
ReviewFilterCriteria,
Expand Down Expand Up @@ -136,17 +138,25 @@ export const ManageReviewerPage: FC = () => {
})

const unapprove = useEventCallback((): void => {
// how to get challenge Id?
// Now we use one specific challenge id for testing
const realChallengeId = 'c713e250-ecb4-4192-8717-d607ddda8db4'
navigate(`${rootRoute}/challenge-management/${realChallengeId}/manage-user`)
if (challengeUuid) {
navigate(`${rootRoute}/challenge-management/${challengeUuid}/manage-user`)
}
})

// Init
useEffect(() => {
search()
}, [challengeId]) // eslint-disable-line react-hooks/exhaustive-deps -- missing dependency: search

// Gets the challenge details by legacyId
useEffect(() => {
getChallengeByLegacyId(+challengeId)
.then(challenge => {
setChallengeUuid(challenge.id)
})
// eslint-disable-next-line react-hooks/exhaustive-deps -- missing dependency: setChallengeUuid
}, [challengeId, getChallengeByLegacyId])

// Page change
const [pageChangeEvent, setPageChangeEvent] = useState(false)
const previousPageChangeEvent = useRef(false)
Expand Down