Pm 959 tc finance integration #1075

vas3a · 2025-05-15T13:00:29Z

Related JIRA Ticket:

https://topcoder.atlassian.net/browse/

What's in this PR?

…x-and-fees PM-1222 - show taxes & fees applied to payments

github-actions · 2025-05-15T13:00:45Z

src/apps/wallet/src/home/tabs/home/HomeTab.tsx

@@ -4,10 +4,11 @@ import { FC, useEffect, useState } from 'react'
 import { UserProfile } from '~/libs/core'
 import { IconOutline, LinkButton, LoadingCircles } from '~/libs/ui'

-import { Balance, WalletDetails } from '../../../lib/models/WalletDetails'
-import { getWalletDetails } from '../../../lib/services/wallet'
+import { Balance } from '../../../lib/models/WalletDetails'


The import statement for WalletDetails has been removed, but it is unclear if this is intentional or if WalletDetails is still needed elsewhere in the code. Please verify if WalletDetails is used in other parts of the file or project.

github-actions · 2025-05-15T13:00:45Z

src/apps/wallet/src/home/tabs/home/HomeTab.tsx

 import { InfoRow } from '../../../lib'
 import { BannerImage, BannerText } from '../../../lib/assets/home'
+import { nullToZero } from '../../../lib/util'


Consider checking if nullToZero is used in the file. If not, ensure that its import is necessary or remove it to keep the code clean.

github-actions · 2025-05-15T13:00:50Z

src/apps/wallet/src/home/tabs/home/HomeTab.tsx

@@ -17,27 +18,8 @@ interface HomeTabProps {
 }

 const HomeTab: FC<HomeTabProps> = () => {
-    const [walletDetails, setWalletDetails] = useState<WalletDetails | undefined>(undefined)
-    const [isLoading, setIsLoading] = useState(false)
+    const { data: walletDetails, isLoading, error }: WalletDetailsResponse = useWalletDetails()


Consider handling the error state more explicitly. Currently, the error variable is being destructured from useWalletDetails(), but there is no logic to handle or display this error within the component. Implementing error handling will improve the user experience by providing feedback when the wallet details cannot be fetched.

github-actions · 2025-05-15T13:00:50Z

src/apps/wallet/src/home/tabs/home/HomeTab.tsx

@@ -17,27 +18,8 @@ interface HomeTabProps {
 }

 const HomeTab: FC<HomeTabProps> = () => {
-    const [walletDetails, setWalletDetails] = useState<WalletDetails | undefined>(undefined)
-    const [isLoading, setIsLoading] = useState(false)
+    const { data: walletDetails, isLoading, error }: WalletDetailsResponse = useWalletDetails()
    const [balanceSum, setBalanceSum] = useState(0)


The balanceSum state is initialized but not used in the provided code snippet. Ensure that this state is necessary, and if it is, implement logic to update and utilize it. If not, consider removing it to clean up the code.

github-actions · 2025-05-15T13:00:52Z

src/apps/wallet/src/home/tabs/home/HomeTab.tsx

@@ -58,7 +40,7 @@ const HomeTab: FC<HomeTabProps> = () => {
                <BannerImage />
            </div>
            {isLoading && <LoadingCircles />}
-            {!isLoading && (
+            {!isLoading && walletDetails && (


Consider adding a null check for walletDetails to ensure it is not null or undefined before rendering the component. This will prevent potential runtime errors if walletDetails is not properly initialized.

github-actions · 2025-05-15T13:00:56Z

src/apps/wallet/src/home/tabs/home/HomeTab.tsx

@@ -75,6 +57,24 @@ const HomeTab: FC<HomeTabProps> = () => {
                        }
                    />

+                    {walletDetails.withdrawalMethod.isSetupComplete && walletDetails.taxForm.isSetupComplete && (


Consider adding a check for walletDetails before accessing its properties to prevent potential runtime errors if walletDetails is undefined.

github-actions · 2025-05-15T13:00:56Z

src/apps/wallet/src/home/tabs/home/HomeTab.tsx

+                        <InfoRow
+                            title='Est. Payment Fees and Tax Withholding %'
+                            // eslint-disable-next-line max-len
+                            value={`Fee: ${nullToZero(walletDetails.estimatedFees)} USD / Tax Withholding: ${nullToZero(walletDetails.taxWithholdingPercentage)}%`}


The comment // eslint-disable-next-line max-len suggests that the line exceeds the maximum length limit. Consider refactoring the line to adhere to the length limit for better readability and maintainability.

github-actions · 2025-05-15T13:00:56Z

src/apps/wallet/src/home/tabs/home/HomeTab.tsx

+                                    icon={IconOutline.ArrowRightIcon}
+                                    size='md'
+                                    link
+                                    to='#payout'


The to prop value '#payout' seems to be a hash link. Ensure that the corresponding element with the id payout exists in the DOM to avoid broken links.

github-actions · 2025-05-15T13:00:59Z

src/apps/wallet/src/home/tabs/winnings/Winnings.module.scss

+    line-height: 20px;
+    font-size: 14px;
+
+    + .taxes {


Consider using a more descriptive class name instead of .mt to improve readability and maintainability of the code.

github-actions · 2025-05-15T13:01:01Z

src/apps/wallet/src/home/tabs/winnings/WinningsTab.tsx

@@ -2,6 +2,7 @@
 /* eslint-disable react/jsx-no-bind */
 import { toast } from 'react-toastify'
 import { AxiosError } from 'axios'
+import { Link } from 'react-router-dom'


The Link import from react-router-dom is added but not used in the code. Consider removing it if it's not needed to avoid unnecessary imports.

github-actions · 2025-05-15T13:01:03Z

src/apps/wallet/src/home/tabs/winnings/WinningsTab.tsx

@@ -12,6 +13,8 @@ import { Winning, WinningDetail } from '../../../lib/models/WinningDetail'
 import { FilterBar } from '../../../lib'
 import { ConfirmFlowData } from '../../../lib/models/ConfirmFlowData'
 import { PaginationInfo } from '../../../lib/models/PaginationInfo'
+import { useWalletDetails, WalletDetailsResponse } from '../../../lib/hooks/use-wallet-details'
+import { nullToZero } from '../../../lib/util'


The function nullToZero is imported but not used in this file. Consider removing the import if it's not needed.

github-actions · 2025-05-15T13:01:07Z

src/apps/wallet/src/home/tabs/winnings/WinningsTab.tsx

@@ -180,6 +185,58 @@ const ListView: FC<ListViewProps> = (props: ListViewProps) => {
        fetchWinnings()
    }

+    function handlePayMeClick(


Consider renaming handlePayMeClick to a more descriptive name like handlePaymentConfirmationClick to better convey the function's purpose.

github-actions · 2025-05-15T13:01:07Z

src/apps/wallet/src/home/tabs/winnings/WinningsTab.tsx

@@ -180,6 +185,58 @@ const ListView: FC<ListViewProps> = (props: ListViewProps) => {
        fetchWinnings()
    }

+    function handlePayMeClick(
+        paymentIds: { [paymentId: string]: Winning },
+        totalAmount: string,


The totalAmount parameter is typed as a string. Consider using a numeric type if this value is intended to represent a monetary amount to avoid potential issues with numeric operations.

github-actions · 2025-05-15T13:01:07Z

src/apps/wallet/src/home/tabs/winnings/WinningsTab.tsx

+                            <div className={`${styles.taxes} ${styles.mt}`}>
+                                You can adjust your payout settings to customize your estimated payment fee and tax withholding percentage in
+                                {' '}
+                                <Link to='#payout'>Payout</Link>


The Link component's to prop is set to '#payout'. Ensure that this hash link correctly corresponds to an existing element ID on the page to avoid broken links.

github-actions · 2025-05-15T13:01:10Z

src/apps/wallet/src/home/tabs/winnings/WinningsTab.tsx

-                                        title: 'Are you sure?',
-                                    })
-                                }}
+                                onPayMeClick={handlePayMeClick}


The function handlePayMeClick is used here, but its definition and implementation are not visible in the diff. Ensure that handlePayMeClick correctly replicates the functionality of the previous inline function, including setting the confirmFlow state and calling processPayouts with the correct parameters.

github-actions · 2025-05-15T13:01:17Z

src/apps/wallet/src/lib/hooks/use-wallet-details.ts

+export interface Response<T> {
+    data?: Readonly<T>
+    error?: Readonly<string>
+    mutate: KeyedMutator<any>


Consider specifying a more precise type for KeyedMutator<any>. Using any can lead to potential type safety issues. If possible, replace any with a more specific type that matches the expected data structure.

github-actions · 2025-05-15T13:01:20Z

src/apps/wallet/src/lib/models/WalletDetails.ts

@@ -17,4 +17,7 @@ export interface WalletDetails {
    taxForm: {
        isSetupComplete: boolean
    }
+    primaryCurrency?: string | null;


Consider using a more specific type for primaryCurrency if possible, such as an enum or a union of string literals representing valid currency codes, to ensure type safety.

github-actions · 2025-05-15T13:01:20Z

src/apps/wallet/src/lib/models/WalletDetails.ts

@@ -17,4 +17,7 @@ export interface WalletDetails {
    taxForm: {
        isSetupComplete: boolean
    }
+    primaryCurrency?: string | null;
+    estimatedFees?: string | null;


The estimatedFees field is currently typed as string | null. If this field represents a numeric value, consider using a numeric type instead to prevent potential issues with string manipulation.

github-actions · 2025-05-15T13:01:20Z

src/apps/wallet/src/lib/models/WalletDetails.ts

@@ -17,4 +17,7 @@ export interface WalletDetails {
    taxForm: {
        isSetupComplete: boolean
    }
+    primaryCurrency?: string | null;
+    estimatedFees?: string | null;
+    taxWithholdingPercentage?: string | null;


The taxWithholdingPercentage field is typed as string | null. If this field is meant to represent a percentage value, consider using a numeric type to facilitate calculations and prevent errors related to string handling.

github-actions · 2025-05-15T13:01:24Z

src/apps/wallet/src/lib/services/wallet.ts

@@ -64,7 +64,7 @@ export async function processWinningsPayments(winningsIds: string[]): Promise<{
    const body = JSON.stringify({
        winningsIds,
    })
-    const url = `${baseUrl}/withdraw`
+    const url = `${WALLET_API_BASE_URL}/withdraw`


Consider verifying that WALLET_API_BASE_URL is defined and has the correct value before using it to construct the URL. This will help prevent potential runtime errors if the environment variable is not set or is incorrect.

github-actions · 2025-05-15T13:01:27Z

src/apps/wallet/src/lib/services/wallet.ts

@@ -107,7 +107,7 @@ export async function resendOtp(transactionId: string): Promise<TransactionRespo
        transactionId,
    })

-    const url = `${baseUrl}/otp/resend`
+    const url = `${WALLET_API_BASE_URL}/otp/resend`


The change from baseUrl to WALLET_API_BASE_URL should be verified to ensure that WALLET_API_BASE_URL is correctly defined and imported in the module. This change could potentially affect the endpoint being called.

github-actions · 2025-05-15T13:01:31Z

src/apps/wallet/src/lib/util/null-to-zero.ts

+ * @param value - The input value which can be a string, `null`, or `undefined`.
+ * @returns The original value if it is a valid string (and not `'null'`), otherwise returns `'0'`.
+ */
+export const nullToZero = (value: string | null | undefined): string => (value === 'null' ? '0' : value ?? '0')


Consider using strict equality checks for null and undefined to ensure type safety. The current implementation uses the nullish coalescing operator (??) which is appropriate, but strict checks can be more explicit and clear.

vas3a and others added 2 commits May 15, 2025 14:32

PM-1222 - show taxes & fees applied to payments

6a78ab2

Merge pull request #1074 from topcoder-platform/PM-1222_banner-for-ta…

13d048a

…x-and-fees PM-1222 - show taxes & fees applied to payments

github-actions bot reviewed May 15, 2025

View reviewed changes

vas3a merged commit f1fd9b7 into shared/dev May 15, 2025
3 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Pm 959 tc finance integration #1075

Pm 959 tc finance integration #1075

vas3a commented May 15, 2025

github-actions bot May 15, 2025

github-actions bot May 15, 2025

github-actions bot May 15, 2025

github-actions bot May 15, 2025

github-actions bot May 15, 2025

github-actions bot May 15, 2025

github-actions bot May 15, 2025

github-actions bot May 15, 2025

github-actions bot May 15, 2025

github-actions bot May 15, 2025

github-actions bot May 15, 2025

github-actions bot May 15, 2025

github-actions bot May 15, 2025

github-actions bot May 15, 2025

github-actions bot May 15, 2025

github-actions bot May 15, 2025

github-actions bot May 15, 2025

github-actions bot May 15, 2025

github-actions bot May 15, 2025

github-actions bot May 15, 2025

github-actions bot May 15, 2025

github-actions bot May 15, 2025

Pm 959 tc finance integration #1075

Pm 959 tc finance integration #1075

Conversation

vas3a commented May 15, 2025

Related JIRA Ticket:

What's in this PR?

github-actions bot May 15, 2025

Choose a reason for hiding this comment

github-actions bot May 15, 2025

Choose a reason for hiding this comment

github-actions bot May 15, 2025

Choose a reason for hiding this comment

github-actions bot May 15, 2025

Choose a reason for hiding this comment

github-actions bot May 15, 2025

Choose a reason for hiding this comment

github-actions bot May 15, 2025

Choose a reason for hiding this comment

github-actions bot May 15, 2025

Choose a reason for hiding this comment

github-actions bot May 15, 2025

Choose a reason for hiding this comment

github-actions bot May 15, 2025

Choose a reason for hiding this comment

github-actions bot May 15, 2025

Choose a reason for hiding this comment

github-actions bot May 15, 2025

Choose a reason for hiding this comment

github-actions bot May 15, 2025

Choose a reason for hiding this comment

github-actions bot May 15, 2025

Choose a reason for hiding this comment

github-actions bot May 15, 2025

Choose a reason for hiding this comment

github-actions bot May 15, 2025

Choose a reason for hiding this comment

github-actions bot May 15, 2025

Choose a reason for hiding this comment

github-actions bot May 15, 2025

Choose a reason for hiding this comment

github-actions bot May 15, 2025

Choose a reason for hiding this comment

github-actions bot May 15, 2025

Choose a reason for hiding this comment

github-actions bot May 15, 2025

Choose a reason for hiding this comment

github-actions bot May 15, 2025

Choose a reason for hiding this comment

github-actions bot May 15, 2025

Choose a reason for hiding this comment