fix(PM-2662): Show only users submission in review tab if challenge is configured to hide submissions #1367
Conversation
…to hide submissions
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| .toLowerCase() === 'true') | ||
| }, [challengeInfo]) | ||
|
|
||
| const canViewSubmissions = useMemo(() => { |
There was a problem hiding this comment.
[💡 readability]
The canViewSubmissions logic could be simplified by directly returning the result of the condition without the if statement. This would improve readability.
| [mappingReviewAppeal, reviewers, submissionsForAggregation], | ||
| ) | ||
|
|
||
| const filterFunc = (submissions: SubmissionRow[]): SubmissionRow[] => submissions |
There was a problem hiding this comment.
[💡 readability]
Consider renaming filterFunc to something more descriptive like filterSubmissionsByViewPermission to clarify its purpose.
| [mappingReviewAppeal, reviewers, submissionsForAggregation], | ||
| ) | ||
|
|
||
| const filterFunc = useCallback((submissions: SubmissionRow[]): SubmissionRow[] => submissions |
There was a problem hiding this comment.
[correctness]
The useCallback hook is used here, which is appropriate for memoizing the filterFunc function. However, ensure that the dependencies [canViewSubmissions, loginUserInfo?.userId] are correct and complete. If any other variables from the outer scope are used within filterFunc, they should be included in the dependency array to prevent stale closures.
Related JIRA Ticket:
https://topcoder.atlassian.net/browse/PM-2662
What's in this PR?