Skip to content

feat: support validation of required boolean values #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RishiRajSahu merged 1 commit into from
Nov 17, 2020
Merged

feat: support validation of required boolean values #360

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions components/Formsy/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,11 @@ Formsy.addValidationRule('isRequired', (values, value, array) => { // eslint-dis
return value.trim().length > 0
}

// we treat any boolean value as value is set
if (_.isBoolean(value)) {
return true
}

// if some unexpected type of `value` has been passed, treat as not provided
return false
})
Expand Down