Skip to content

Conversation

@vikasrohit
Copy link

@nlitwin @aselbie @samsep do you see any issue with this renaming of css class name? container is very generic class and is probable for css overriding in the calling app. e.g. in tc-site, this class is causing displacement of loading icon when showing nav bar in tc-site.

@aselbie
Copy link
Contributor

aselbie commented Apr 12, 2016

I have no problem with that naming pattern. I think though, that we should move away from webpack extension resolver altogether, since it is incompatible with the default node require system, and therefore doesn't play well with other systems like Mocha.

@vikasrohit
Copy link
Author

Thanks @aselbie However, I didn't get the point of extension resolver and its relevance to this change. Can you please elaborate more on this?

@nlitwin
Copy link
Contributor

nlitwin commented Apr 13, 2016

I was wondering the same :)

@vikasrohit vikasrohit merged commit b06194f into dev Apr 14, 2016
@vikasrohit
Copy link
Author

Merged for now. Please let me know if you face any problems with after this change.

@vikasrohit vikasrohit deleted the feature/fix-loader-css-conflict branch October 24, 2017 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants