Skip to content

reviewer role restriction #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 23, 2022
Merged

reviewer role restriction #91

merged 9 commits into from
Mar 23, 2022

Conversation

LieutenantRoger
Copy link
Contributor

No description provided.

Copy link
Contributor

@ThomasKranitsas ThomasKranitsas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comment

@@ -243,6 +243,13 @@ async function init (currentUser, challengeId, resource, isCreated) {
const handle = resource.memberHandle
const memberId = await helper.getMemberIdByHandle(resource.memberHandle)

// check if the resource is reviewer role and has already made a submission in the challenge
const submissionsRes = await helper.getRequest(`${config.SUBMISSIONS_API_URL}`, { challengeId: challengeId, perPage: 100 })
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are you fetching all submissions and then checking for the member id instead of simply passing the memberId property to the query and only receive submission for the particular member?

@LieutenantRoger LieutenantRoger merged commit 05079f8 into develop Mar 23, 2022
@rakibansary rakibansary deleted the issue_reviewer_role branch November 22, 2023 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants