reviewer role restriction #91
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomasKranitsas
suggested changes
Mar 22, 2022
ThomasKranitsas
approved these changes
Mar 23, 2022
src/services/ResourceService.js
Outdated
| @@ -243,6 +243,13 @@ async function init (currentUser, challengeId, resource, isCreated) { | |||
| const handle = resource.memberHandle | |||
| const memberId = await helper.getMemberIdByHandle(resource.memberHandle) | |||
|
|
|||
| // check if the resource is reviewer role and has already made a submission in the challenge | |||
| const submissionsRes = await helper.getRequest(`${config.SUBMISSIONS_API_URL}`, { challengeId: challengeId, perPage: 100 }) | |||
There was a problem hiding this comment.
why are you fetching all submissions and then checking for the member id instead of simply passing the memberId property to the query and only receive submission for the particular member?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.