Fix lint errors and correct path #7

billsedison · 2025-07-31T15:36:41Z

http://www.topcoder.com/challenge-details/30377549/?type=develop

Fix TypeScript Lint Errors
Remove /api Prefix from All Endpoints

github-actions · 2025-07-31T15:36:52Z

prisma/migrate.ts

@@ -57,7 +57,7 @@ let projectCategoryMap: Record<string, ProjectTypeMap> = {};
 let reviewItemCommentTypeMap: Record<string, string> = {};

 // Global submission map to store submission information.
-let submissionMap: Record<string, Record<string, string>> = {};
+const submissionMap: Record<string, Record<string, string>> = {};


Consider reviewing other variables in the file to ensure consistent use of const where appropriate. Changing let to const is a good practice when the variable is not reassigned, but consistency across similar variables can improve readability and maintainability.

github-actions · 2025-07-31T15:36:55Z

prisma/migrate.ts

@@ -287,15 +287,15 @@ function processLookupFiles() {
 /**
 * Read submission data from resource_xxx.json, upload_xxx.json and submission_xxx.json.
 */
-async function initSubmissionMap() {
+function initSubmissionMap() {


The function initSubmissionMap was changed from async to a regular function. Ensure that there are no asynchronous operations within this function that require the use of await. If there are, the function should remain async to handle promises correctly.

github-actions · 2025-07-31T15:36:58Z

prisma/migrate.ts

@@ -313,14 +313,14 @@ async function initSubmissionMap() {
    const filePath = path.join(DATA_DIR, f);
    console.log(`Reading submission data from ${f}`);
    const jsonData = readJson(filePath)['submission'];
-    for (let d of jsonData) {
+    for (const d of jsonData) {


Consider using const for the variable jsonData on line 315 since its value is not reassigned.

github-actions · 2025-07-31T15:37:00Z

prisma/migrate.ts

@@ -342,12 +342,17 @@ async function initSubmissionMap() {
    const filePath = path.join(DATA_DIR, f);
    console.log(`Reading upload data from ${f}`);
    const jsonData = readJson(filePath)['upload'];
-    for (let d of jsonData) {
-      if (d['upload_status_id'] === '1' && d['upload_type_id'] === '1' && d['resource_id']) {
+    for (const d of jsonData) {


Consider using const instead of let for d since it is not reassigned within the loop.

github-actions · 2025-07-31T15:37:01Z

prisma/migrate.ts

        // get submission info
-        uploadCount += 1
+        uploadCount += 1;


Ensure consistent use of semicolons throughout the code. A semicolon was added here, so verify other parts of the code for consistency.

github-actions · 2025-07-31T15:37:04Z

prisma/migrate.ts

@@ -387,16 +392,17 @@ async function initSubmissionMap() {
      }
    }
  }
-  console.log(`Read resource count: ${resourceCount}, submission resource count: ${validResourceCount}`);
+  console.log(


The console.log statement has been split into multiple lines. Consider keeping it on a single line for better readability unless it exceeds the maximum line length.

github-actions · 2025-07-31T15:37:06Z

prisma/migrate.ts

@@ -1050,7 +1056,7 @@ async function migrate() {

  // init resource-submission data
  console.log('Starting resource/submission import...');
-  await initSubmissionMap();
+  initSubmissionMap();


The await keyword has been removed from the initSubmissionMap() call. If initSubmissionMap() is an asynchronous function and its completion is necessary before proceeding, consider adding await back to ensure the function completes before moving on to the next steps.

github-actions · 2025-07-31T15:37:15Z

src/api/appeal/appeal.controller.ts

-          code: errorResponse.code 
+        throw new NotFoundException({
+          message: `Appeal with ID ${appealId} was not found`,
+          code: errorResponse.code,


Trailing comma is unnecessary in the object literal. Consider removing it for consistency with the rest of the code style.

github-actions · 2025-07-31T15:37:17Z

src/api/appeal/appeal.controller.ts

-          code: errorResponse.code 
+        throw new NotFoundException({
+          message: `Appeal with ID ${appealId} was not found`,
+          code: errorResponse.code,


Consider removing the trailing comma after errorResponse.code to adhere to standard JavaScript object syntax.

github-actions · 2025-07-31T15:37:20Z

src/api/appeal/appeal.controller.ts

    const { page = 1, perPage = 10 } = paginationDto || {};
    const skip = (page - 1) * perPage;
-
+
    try {
      // Build where clause for filtering
      const whereClause: any = {};
      if (resourceId) whereClause.resourceId = resourceId;
      if (challengeId) whereClause.challengeId = challengeId;
      if (reviewId) whereClause.appealId = reviewId;


The condition if (reviewId) whereClause.appealId = reviewId; seems to be setting appealId instead of reviewId. Verify if this is intentional or if it should be whereClause.reviewId = reviewId;.

github-actions · 2025-07-31T15:37:23Z

src/api/appeal/appeal.controller.ts

@@ -326,11 +345,13 @@ export class AppealController {
        }),


The indentation of the closing bracket on line 345 should match the opening bracket on line 326 for better readability.

github-actions · 2025-07-31T15:37:23Z

src/api/appeal/appeal.controller.ts

@@ -326,11 +345,13 @@ export class AppealController {
        }),
        this.prisma.appealResponse.count({
          where: whereClause,
-        })
+        }),


The indentation of the closing bracket on line 348 should match the opening bracket on line 346 for consistency.

github-actions · 2025-07-31T15:37:26Z

src/api/contact/contactRequests.controller.ts

@@ -19,16 +19,16 @@ import { PrismaService } from '../../shared/modules/global/prisma.service';

 @ApiTags('Contact Requests')
 @ApiBearerAuth()
-@Controller('/api')
+@Controller('/')


Changing the controller path from /api to / might affect the routing of the application. Ensure that this change is intentional and that all routes are correctly updated to reflect this new path.

github-actions · 2025-07-31T15:37:29Z

src/api/health-check/healthCheck.controller.ts

@@ -23,7 +23,7 @@ export class GetHealthCheckResponseDto {
 }

 @ApiTags('Healthcheck')
-@Controller('/api')
+@Controller('/')


The change from @Controller('/api') to @Controller('/') alters the base path for the health check endpoint. Ensure that this change aligns with the intended routing structure and does not inadvertently affect other endpoints or the application's routing logic.

github-actions · 2025-07-31T15:37:32Z

src/api/project-result/projectResult.controller.ts

@@ -18,7 +23,7 @@ import { PrismaErrorService } from '../../shared/modules/global/prisma-error.ser

 @ApiTags('ProjectResult')
 @ApiBearerAuth()
-@Controller('/api')
+@Controller('/')


The change from @Controller('/api') to @Controller('/') alters the base path for the controller. Ensure that this change is intentional and that all routes are updated accordingly in the application to prevent routing issues.

github-actions · 2025-07-31T15:37:36Z

src/api/project-result/projectResult.controller.ts

@@ -65,22 +71,27 @@ export class ProjectResultController {
        }),


Consider aligning the indentation of the this.prisma.challengeResult.count call with the surrounding code for better readability.

github-actions · 2025-07-31T15:37:37Z

src/api/project-result/projectResult.controller.ts

@@ -65,22 +71,27 @@ export class ProjectResultController {
        }),
        this.prisma.challengeResult.count({
          where: { challengeId },
-        })
+        }),


Ensure consistent use of trailing commas in multi-line array and object literals for better diff readability and to adhere to common linting rules.

github-actions · 2025-07-31T15:37:40Z

src/api/review-application/reviewApplication.controller.ts

@@ -18,7 +27,7 @@ import { isAdmin, JwtUser } from 'src/shared/modules/global/jwt.service';
 import { ReviewApplicationService } from './reviewApplication.service';

 @ApiTags('Review Application')
-@Controller('/api/review-applications')
+@Controller('/review-applications')


The path change from /api/review-applications to /review-applications might affect existing API consumers. Ensure that this change is intentional and that any necessary updates to documentation or client code are made to reflect this change.

github-actions · 2025-07-31T15:37:46Z

src/api/review-application/reviewApplication.service.ts

-        role: dto.role
-      }
+        role: dto.role,
+      },
    });
    if (existing && existing.length > 0) {
      throw new ConflictException('Reviewer has submitted application before.');


Consider using double quotes for the string in ConflictException to maintain consistency with the other exception messages.

github-actions · 2025-07-31T15:37:49Z

src/api/review-application/reviewApplication.service.ts

-        }
-      }
+          gte: beginDate,
+        },


Trailing comma added here. Ensure this is consistent with the project's linting rules. If the rules require trailing commas, this is correct; otherwise, it should be removed.

github-actions · 2025-07-31T15:37:52Z

src/api/review-application/reviewApplication.service.ts

@@ -196,43 +207,50 @@ export class ReviewApplicationService {
   * @param entityList review application entity list
   * @param status application status
   */
-  private async sendEmails(entityList, status: ReviewApplicationStatus) {
+  private async sendEmails(
+    entityList: any[],


Consider specifying a more precise type for entityList instead of using any[] to improve type safety.

github-actions · 2025-07-31T15:37:53Z

src/api/review-application/reviewApplication.service.ts

    // All review application has same review opportunity and same challenge id.
    const challengeId = entityList[0].opportunity.challengeId;
    // get member id list
-    const userIds = entityList.map(e => e.userId);
+    const userIds: string[] = entityList.map((e: any) => e.userId as string);


The type assertion as string is used here. Ensure that userId is always a string to avoid runtime errors.

github-actions · 2025-07-31T15:37:53Z

src/api/review-application/reviewApplication.service.ts

-    for (let entity of entityList) {
-      const payload:EventBusSendEmailPayload = new EventBusSendEmailPayload();
+    for (const entity of entityList) {
+      const payload: EventBusSendEmailPayload = new EventBusSendEmailPayload();
      payload.sendgrid_template_id = sendgridTemplateId;


Consider checking if userEmailMap.get(entity.userId) returns a valid email before adding it to payload.recipients to avoid sending emails to undefined addresses.

github-actions · 2025-07-31T15:37:56Z

src/api/review-history/reviewHistory.controller.ts


 @ApiTags('Review History')
-@Controller('/api/review-history')
+@Controller('/review-history')


The change from '/api/review-history' to '/review-history' in the @Controller decorator modifies the endpoint path. Ensure this change is intentional and aligns with the application's routing requirements.

github-actions · 2025-07-31T15:37:58Z

src/api/review-history/reviewHistory.controller.ts

    // Check user permission
    const authUser: JwtUser = req['user'] as JwtUser;
    if (authUser.userId !== userId && !isAdmin(authUser)) {
-      throw new ForbiddenException('You cannot check this user\'s review history')
+      throw new ForbiddenException(
+        "You cannot check this user's review history",


Consider using single quotes for consistency, as the rest of the code uses single quotes for strings.

github-actions · 2025-07-31T15:38:01Z

src/api/review-opportunity/reviewOpportunity.controller.ts

@@ -30,7 +30,7 @@ import { JwtUser } from 'src/shared/modules/global/jwt.service';
 import { ReviewOpportunityService } from './reviewOpportunity.service';

 @ApiTags('Review Opportunity')
-@Controller('/api/review-opportunities')
+@Controller('/review-opportunities')


The change in the path from /api/review-opportunities to /review-opportunities might affect the routing if other parts of the application or external clients are expecting the original path. Ensure that this change is intentional and that all necessary updates are made to accommodate this new path.

github-actions · 2025-07-31T15:38:19Z