Skip to content

Support multiple mentions - right now it only sends mention event for first mention in the post #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vikasrohit opened this issue Apr 26, 2018 · 3 comments
Assignees

Comments

@vikasrohit
Copy link

@gondzo can you please take care of it?

@gondzo gondzo added this to the notification fixes milestone May 4, 2018
@maxceem
Copy link
Contributor

maxceem commented May 11, 2018

@gondzo
When I create a post https://connect.topcoder-dev.com/projects/2000 and mention some people. I get only notifications.action.email.connect.project.topic.created event in my locally deployed tc-notifications service. It looks like mention events are not being sent to the KAFKA at all.

PS. tc-notification source code looks like it supports multiple mentions.

@vikasrohit
Copy link
Author

@maxceem We don't send mention event from message service rather tc-notifications actually parses the content of the new topic/post in case of notifications.action.email.connect.project.topic.created or notifications.action.email.connect.project.post.created events and internally changes the event type when sending email to the team members. So, yes, it does not send any event to the bus right now.
We can move that logic to tc-message-service, if that makes more sense.

@maxceem
Copy link
Contributor

maxceem commented May 11, 2018

@vikasrohit thank you. I've missed that moment. I think it's totally fine to keep like it's done now. Will make sure mentions are processed correctly.

maxceem added a commit to maxceem/tc-notifications that referenced this issue May 14, 2018
… only sends mention event for first mention in the post
maxceem added a commit to maxceem/tc-notifications that referenced this issue May 14, 2018
… only sends mention event for first mention in the post
@gondzo gondzo closed this as completed Jun 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants