Skip to content

Add new filters for projects list (without ID) #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 20, 2019
Merged

Add new filters for projects list (without ID) #256

merged 2 commits into from
Feb 20, 2019

Conversation

maxceem
Copy link
Contributor

@maxceem maxceem commented Feb 19, 2019

winning submission for challenge 30083089 - Topcoder Connect - Filter project table by columns, fix for issue #245

  • additionally was removed support for filtering by ID substring, so we don't need to reindex projects and change ID field type from long to string in ES index.
  • also I've put back the support to filter by type, as it was removed in the challenge together with filtering by type in connect, but I think we may can keep it in project service

@maxceem maxceem requested a review from RishiRajSahu February 19, 2019 11:18
@maxceem maxceem mentioned this pull request Feb 19, 2019
Closed
RishiRajSahu
RishiRajSahu approved these changes Feb 20, 2019
View reviewed changes
Copy link
Contributor

@RishiRajSahu RishiRajSahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RishiRajSahu RishiRajSahu merged commit 80ab3f2 into dev Feb 20, 2019
@vikasrohit vikasrohit deleted the feature/new-project-filters-2 branch July 29, 2019 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@RishiRajSahu RishiRajSahu RishiRajSahu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@maxceem @RishiRajSahu