Skip to content

[PROD] Hotfix /milestone completion date #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: change aws s3 cli to aws-sdk
merged 3 commits into from
Nov 7, 2019
Merged

[PROD] Hotfix /milestone completion date #407

merged 3 commits into from
Nov 7, 2019

Conversation

@maxceem
Copy link
Contributor

@maxceem maxceem commented Nov 7, 2019

Supporting fixes for Connect App ticket appirio-tech/connect-app#3210

  • only admins should be able to edit completionDate and actualStartDate
  • fix issue: it was validated against startDate instead of actualStartDate so comletionDate couldn’t be earlier than startDate which is not important when there is actualStartDate which could be earlier
  • there was another error even if comletionDate passes the validation: comletionDate.diff is not a function

@maxceem
Merge pull request #382 from r0hit-gupta/issue-381-fix
050c2dd 
Fix for issue-381
@maxceem
fix: issues during updating milestone completionDate
6f0fa68
@maxceem
fix: "projectUpdatedKafkaHandler" unit test
f585f9a 
Project has been indexed in a wrong way for unit test.
Also, we have to wait until the index is refreshed to make tests consistent.
@maxceem maxceem requested a review from vikasrohit November 7, 2019 04:18
@maxceem
Copy link
Contributor Author

maxceem commented Nov 7, 2019

@vikasrohit I've created this HOTFIX for PROD by cherry-picking some commits from DEV.
It works good on DEV.

vikasrohit
vikasrohit approved these changes Nov 7, 2019
View reviewed changes
Copy link

@vikasrohit vikasrohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vikasrohit vikasrohit merged commit d70a183 into master Nov 7, 2019
@maxceem maxceem mentioned this pull request Dec 13, 2019
Merged
@eisbilir eisbilir deleted the hotfix/milestone-completion-date branch November 9, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@vikasrohit vikasrohit vikasrohit approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@maxceem @vikasrohit