fix(PM-1510): added existing membership to the copilot application #840

hentrymartin · 2025-07-30T08:24:31Z

TBA

github-actions · 2025-07-30T08:24:47Z

src/routes/copilotOpportunityApply/list.js

@@ -9,11 +9,23 @@ const permissions = tcMiddleware.permissions;

 module.exports = [
  permissions('copilotApplications.view'),
-  (req, res, next) => {
+  async (req, res, next) => {


The function has been changed to an async function, but there is no error handling for the asynchronous operations. Consider using a try-catch block to handle potential errors from the await calls.

github-actions · 2025-07-30T08:24:47Z

src/routes/copilotOpportunityApply/list.js

+      }
+    });
+
+    if (!opportunity) {


The error message 'No opportunity found' could be more descriptive to help with debugging. Consider including the opportunityId in the error message to provide more context.

github-actions · 2025-07-30T08:24:50Z

src/routes/copilotOpportunityApply/list.js

@@ -41,7 +53,15 @@ module.exports = [
      ],
      order: [[sortParams[0], sortParams[1]]],
    })
-      .then(copilotApplications => res.json(copilotApplications))
+      .then(copilotApplications => {
+        return models.ProjectMember.getActiveProjectMembers(opportunity.projectId).then((members) => {


Consider handling the case where opportunity.projectId might be undefined or null to prevent potential errors when calling getActiveProjectMembers.

github-actions · 2025-07-30T08:24:50Z

src/routes/copilotOpportunityApply/list.js

+        return models.ProjectMember.getActiveProjectMembers(opportunity.projectId).then((members) => {
+          return res.json(copilotApplications.map(application => {
+            return Object.assign({}, application, {
+              existingMembership: members.find(m => m.userId === application.userId),


The find method will return undefined if no matching member is found. Ensure that the rest of the code handles this case appropriately, especially if existingMembership is expected to be an object.

github-actions · 2025-07-30T08:48:01Z

src/routes/copilotOpportunity/assign.js

@@ -45,11 +45,17 @@ module.exports = [
        throw err;
      }

+      const copilotRequest = await models.CopilotRequest.findOne({


Consider checking if copilotRequest is null or undefined after fetching it from the database. This will help prevent potential runtime errors if the request is not found.

github-actions · 2025-07-30T08:48:01Z

src/routes/copilotOpportunity/assign.js

      const application = await models.CopilotApplication.findOne({
        where: { id: applicationId, opportunityId: copilotOpportunityId },
        transaction: t,
      });

+


Remove the extra blank line here to maintain consistent formatting and readability.

github-actions · 2025-07-30T08:48:05Z

src/routes/copilotOpportunity/assign.js

+      if (existingMember) {
+        if (['copilot', 'manager'].includes(existingMember.role)) {
+
+          updateCopilotOpportunity();


The function updateCopilotOpportunity() is called without await. If this function performs asynchronous operations, consider using await to ensure it completes before proceeding.

github-actions · 2025-07-30T08:48:05Z

src/routes/copilotOpportunity/assign.js

+            projectMember.get({ plain: true }),
+            existingMember);
+
+            updateCopilotOpportunity();


Similar to line 109, updateCopilotOpportunity() is called without await. If this function is asynchronous, use await to ensure proper execution order.

github-actions · 2025-07-30T08:48:05Z

src/routes/copilotOpportunity/assign.js

+      };
+
+      const existingMember = activeMembers.find(item => item.userId === userId);
+      if (existingMember) {


The logic for checking existingMember and its role could be optimized. Consider combining the role check with the initial find operation to reduce complexity and improve readability.

github-actions · 2025-07-30T08:48:05Z

src/routes/copilotOpportunity/assign.js

+          updateCopilotOpportunity();
+
+        } else {
+          await models.ProjectMember.update({


The await keyword is used here, but the surrounding code does not handle potential errors that might arise from this asynchronous operation. Consider adding error handling to manage any exceptions that may occur.

github-actions · 2025-07-30T08:51:07Z

src/routes/copilotOpportunity/assign.js

+
+      const existingMember = activeMembers.find(item => item.userId === userId);
+      if (existingMember) {
+        req.log.debug(`User already part of project: ${JSON.stringify(existingMember)}`);


Consider handling the case where JSON.stringify(existingMember) might throw an error if existingMember contains circular references. You could use a try-catch block or a safe stringification method.

github-actions · 2025-07-30T08:51:07Z

src/routes/copilotOpportunity/assign.js

+      if (existingMember) {
+        req.log.debug(`User already part of project: ${JSON.stringify(existingMember)}`);
+        if (['copilot', 'manager'].includes(existingMember.role)) {
+          req.log.debug(`User is a copilot or manager`);


The debug log message User is a copilot or manager could be more descriptive by including the user's role. Consider logging the actual role for better traceability.

github-actions · 2025-07-30T08:51:08Z

src/routes/copilotOpportunity/assign.js

+          req.log.debug(`User is a copilot or manager`);
+          updateCopilotOpportunity();
+        } else {
+          req.log.debug(`User has read/write role`);


The debug log message User has read/write role might be misleading if the user has other roles. Consider specifying the exact role or roles the user has for clarity.

github-actions · 2025-07-30T08:51:11Z

src/routes/copilotOpportunity/assign.js

+            },
+          });
+
+          req.log.debug(`Updated project member: ${JSON.stringify(projectMember.get({plain: true}))}`);


Consider handling potential errors that might occur during the JSON.stringify operation. If projectMember.get({plain: true}) contains circular references or other non-serializable data, JSON.stringify could throw an error.

github-actions · 2025-07-30T08:51:11Z

src/routes/copilotOpportunity/assign.js

+            RESOURCES.PROJECT_MEMBER,
+            projectMember.get({ plain: true }),
+            existingMember);
+          req.log.debug(`Member updated in kafka`);


The log message Member updated in kafka could be more descriptive. Consider including additional context, such as the member ID or other relevant details, to make the log more informative.

github-actions · 2025-07-30T09:07:35Z

src/routes/copilotOpportunityApply/list.js

+      .then(copilotApplications => {
+        return models.ProjectMember.getActiveProjectMembers(opportunity.projectId).then((members) => {
+          const applications = copilotApplications.get({plain: true});
+          req.log.debug(`Fetched existing active members ${JSON.stringify(members)}`);


Consider handling potential errors or exceptions that might occur during the JSON.stringify operation, especially if the members object contains circular references or non-serializable data.

github-actions · 2025-07-30T09:07:35Z

src/routes/copilotOpportunityApply/list.js

+        return models.ProjectMember.getActiveProjectMembers(opportunity.projectId).then((members) => {
+          const applications = copilotApplications.get({plain: true});
+          req.log.debug(`Fetched existing active members ${JSON.stringify(members)}`);
+          req.log.debug(`Applications ${JSON.stringify(applications)}`);


Similar to the previous comment, ensure that applications can be safely serialized with JSON.stringify without causing runtime errors due to circular references or non-serializable data.

github-actions · 2025-07-30T09:07:35Z

src/routes/copilotOpportunityApply/list.js

+          req.log.debug(`Fetched existing active members ${JSON.stringify(members)}`);
+          req.log.debug(`Applications ${JSON.stringify(applications)}`);
+          return res.json(applications.map(application => {
+            req.log.debug(`Existing member to application ${JSON.stringify(members.find(m => m.userId === application.userId))}`);


The debug log statement may produce a large output if members is a large array. Consider truncating the log or summarizing the information to avoid excessive logging, which could impact performance or readability.

github-actions · 2025-07-30T11:06:02Z

src/routes/copilotOpportunityApply/list.js

@@ -31,19 +31,42 @@ module.exports = [
    canAccessAllApplications ? {} : { createdBy: userId },
    );



The opportunityId variable is used here, but it is not clear from the diff where it is defined or assigned. Ensure that opportunityId is properly defined and assigned a value before this line.

github-actions · 2025-07-30T11:06:02Z

src/routes/copilotOpportunityApply/list.js

+      })
+        .then(copilotApplications => {
+          return models.ProjectMember.getActiveProjectMembers(opportunity.projectId).then((members) => {
+            const applications = copilotApplications.get({plain: true});


The copilotApplications.get({plain: true}) method is used, but copilotApplications is an array returned by findAll. This might cause an error since get is not a method on arrays. Consider iterating over copilotApplications and calling get on each element if needed.

github-actions · 2025-07-30T11:20:32Z

src/routes/copilotOpportunityApply/list.js

+        order: [[sortParams[0], sortParams[1]]],
+      })
+        .then(copilotApplications => {
+          req.log.debug(`CopilotApplications ${JSON.stringify(copilotApplications)}`);


Consider using a more descriptive log message to clarify what copilotApplications represents in this context.

github-actions · 2025-07-30T11:20:32Z

src/routes/copilotOpportunityApply/list.js

+          req.log.debug(`CopilotApplications ${JSON.stringify(copilotApplications)}`);
+          return models.ProjectMember.getActiveProjectMembers(opportunity.projectId).then((members) => {
+            req.log.debug(`Fetched existing active members ${JSON.stringify(members)}`);
+            req.log.debug(`Applications ${JSON.stringify(copilotApplications)}`);


The log message for Applications is redundant with the previous log message for CopilotApplications. Consider removing one of them to avoid unnecessary duplication.

github-actions · 2025-07-30T11:20:32Z

src/routes/copilotOpportunityApply/list.js

+            req.log.debug(`Fetched existing active members ${JSON.stringify(members)}`);
+            req.log.debug(`Applications ${JSON.stringify(copilotApplications)}`);
+            return res.json(copilotApplications.map(application => {
+              req.log.debug(`Existing member to application ${JSON.stringify(members.find(m => m.userId === application.userId))}`);


The log message Existing member to application could be more descriptive to clearly indicate what is being logged. Consider rephrasing for better clarity.

github-actions · 2025-07-30T11:46:49Z

src/routes/copilotOpportunityApply/list.js

+          return models.ProjectMember.getActiveProjectMembers(opportunity.projectId).then((members) => {
+            req.log.debug(`Fetched existing active members ${JSON.stringify(members)}`);
+            req.log.debug(`Applications ${JSON.stringify(copilotApplications)}`);
+            const enrichedApplications = copilotApplications.map(application => {


Consider using const for enrichedApplications only if it is not reassigned later in the code. If it is reassigned, let would be more appropriate.

github-actions · 2025-07-30T11:46:49Z

src/routes/copilotOpportunityApply/list.js

+            req.log.debug(`Fetched existing active members ${JSON.stringify(members)}`);
+            req.log.debug(`Applications ${JSON.stringify(copilotApplications)}`);
+            const enrichedApplications = copilotApplications.map(application => {
+              req.log.debug(`Existing member to application ${JSON.stringify(members.find(m => m.userId === application.userId))}`);


The debug log message could be more descriptive. Consider specifying which application is being processed by including relevant details from the application object.

github-actions · 2025-07-30T11:46:49Z

src/routes/copilotOpportunityApply/list.js

+              });
+            });
+
+            req.log.debug(`Enriched Applications ${JSON.stringify(enrichedApplications)}`);


The debug log message could be more informative by including the number of enriched applications. Consider adding enrichedApplications.length to the log message.

github-actions · 2025-07-30T12:13:36Z

src/routes/copilotOpportunityApply/list.js

+            req.log.debug(`Fetched existing active members ${JSON.stringify(members)}`);
+            req.log.debug(`Applications ${JSON.stringify(copilotApplications)}`);
+            const enrichedApplications = copilotApplications.map(application => {
+              req.log.debug(`Existing member to application ${JSON.stringify()}`);


The JSON.stringify() function is called without any arguments, which will result in an empty string being logged. Consider passing the object you intend to stringify.

github-actions · 2025-07-30T12:37:58Z

src/routes/copilotOpportunityApply/list.js

+            req.log.debug(`Fetched existing active members ${JSON.stringify(members)}`);
+            req.log.debug(`Applications ${JSON.stringify(copilotApplications)}`);
+            const enrichedApplications = copilotApplications.map(application => {
+              const m = members.find(m => m.userId === application.userId);


The debug log statement was removed but the comment remains. Consider removing the comment as it is not necessary to keep commented-out code.

github-actions · 2025-07-30T12:37:59Z

src/routes/copilotOpportunityApply/list.js

+            });
+
+            req.log.debug(`Enriched Applications ${JSON.stringify(enrichedApplications)}`);
+            res.status(200).send(enrichedApplications);


The response method has been changed from res.json to res.status(200).send. Ensure that this change is intentional and that send is the appropriate method for sending the enriched applications. If res.json was previously used to automatically set the content-type to application/json, verify that send achieves the same result.

github-actions · 2025-07-30T12:51:03Z

src/routes/copilotOpportunityApply/list.js

+            req.log.debug(`Applications ${JSON.stringify(copilotApplications)}`);
+            const enrichedApplications = copilotApplications.map(application => {
+              const m = members.find(m => m.userId === application.userId);
+              req.log.debug(`Existing member to application ${JSON.stringify(Object.assign({}, application, {


Consider using the spread operator instead of Object.assign for better readability and consistency with modern JavaScript practices. Example: { ...application, existingMembership: m }.

github-actions · 2025-07-30T13:05:32Z

src/routes/copilotOpportunityApply/list.js

+            req.log.debug(`Applications ${JSON.stringify(copilotApplications)}`);
+            const enrichedApplications = copilotApplications.map(application => {
+              const m = members.find(m => m.userId === application.userId);
+              req.log.debug(`Existing member to application ${JSON.stringify(Object.assign({}, application, m ? {


Consider using the spread operator for merging objects instead of Object.assign for better readability and performance. For example: {...application, ...(m ? { existingMembership: m } : {})}.

github-actions · 2025-07-30T13:08:51Z

src/routes/copilotOpportunityApply/list.js

+            const enrichedApplications = copilotApplications.map(application => {
+              const m = members.find(m => m.userId === application.userId);
+
+              // Using spread operator fails in lint check


Consider removing the commented-out code if it is no longer needed to keep the codebase clean.

github-actions · 2025-07-30T13:08:51Z

src/routes/copilotOpportunityApply/list.js

+              // While Object.assign fails silently during run time
+              // So using this method
+              const enriched = {
+                id: application.id,


Instead of manually listing all properties, consider using a utility function or library to clone objects if the goal is to avoid using Object.assign or the spread operator. This can help reduce potential errors and improve maintainability.

github-actions · 2025-07-30T13:46:21Z

src/routes/copilotOpportunity/assign.js

+          transaction: t,
+        });
+
+        req.log.debug(`Updating other applications: ${JSON.stringify(copilotRequest)}`);


The log message here seems to be incorrect. It mentions copilotRequest but the operation is updating other applications. Consider updating the log message to reflect the correct context, such as Updating other applications status to CANCELED.

github-actions · 2025-07-30T13:46:23Z

src/routes/copilotOpportunity/assign.js

+          }
+        });
+
+        req.log.debug(`All updations done`);


Consider removing or rephrasing the debug log message to be more specific about what updates were completed. This will help in understanding the context of the log when reviewing logs later.

github-actions · 2025-07-30T13:46:26Z

src/routes/copilotOpportunity/assign.js

+          req.log.debug(`Member updated in kafka`);
+          updateCopilotOpportunity();
+        }
+        t.commit();


Consider handling potential errors when committing the transaction with t.commit(). If the commit fails, it might leave the application in an inconsistent state. You could use a try-catch block to manage this scenario and ensure proper error handling.

github-actions · 2025-07-30T14:33:30Z

src/routes/copilotOpportunity/assign.js

-        err.status = 400;
-        throw err;
+      const updateCopilotOpportunity = async () => {
+        const transaction = await models.sequelize.transaction();


The transaction is initialized here but not used in a try-catch block. Consider wrapping the transaction logic in a try-catch block to ensure that the transaction is properly committed or rolled back in case of an error.

github-actions · 2025-07-30T14:33:33Z

src/routes/copilotOpportunity/assign.js

+        });
+
+        req.log.debug(`All updations done`);
+        transaction.commit();


Consider adding error handling for the transaction.commit() operation to ensure that any issues during the commit process are properly managed. This could involve wrapping the commit in a try-catch block and handling any potential exceptions.

github-actions · 2025-07-30T14:33:36Z

src/routes/copilotOpportunity/assign.js

+            projectMember.get({ plain: true }),
+            existingMember);
+          req.log.debug(`Member updated in kafka`);
+          updateCopilotOpportunity();


The removal of t.commit(); suggests that the transaction might not be committed anymore. Ensure that the transaction is being properly handled to avoid potential data inconsistencies.

github-actions · 2025-07-30T14:55:54Z

src/routes/copilotOpportunity/assign.js

@@ -1,11 +1,13 @@
 import _ from 'lodash';
 import validate from 'express-validation';
 import Joi from 'joi';
+import config from 'config';


The config import is added but not used in the current diff. Ensure that it is necessary, or remove it if it is not used.

github-actions · 2025-07-30T14:55:54Z

src/routes/copilotOpportunity/assign.js


 import models from '../../models';
 import util from '../../util';
 import { PERMISSION } from '../../permissions/constants';
-import { COPILOT_APPLICATION_STATUS, COPILOT_OPPORTUNITY_STATUS, COPILOT_REQUEST_STATUS, EVENT, INVITE_STATUS, PROJECT_MEMBER_ROLE, RESOURCES } from '../../constants';
+import { CONNECT_NOTIFICATION_EVENT, COPILOT_APPLICATION_STATUS, COPILOT_OPPORTUNITY_STATUS, COPILOT_REQUEST_STATUS, EVENT, INVITE_STATUS, PROJECT_MEMBER_ROLE, RESOURCES, TEMPLATE_IDS } from '../../constants';
+import { getCopilotTypeLabel } from '../../utils/copilot';


The getCopilotTypeLabel import is added but not used in the current diff. Ensure that it is necessary, or remove it if it is not used.

github-actions · 2025-07-30T14:55:57Z

src/routes/copilotOpportunity/assign.js

-        throw err;
+      const updateCopilotOpportunity = async () => {
+        const transaction = await models.sequelize.transaction();
+        const memberDetails = await util.getMemberDetailsByUserIds([application.userId], req.log, req.id);


Consider adding error handling for the getMemberDetailsByUserIds function call to manage cases where the function might fail or return an unexpected result.

github-actions · 2025-07-30T14:55:57Z

src/routes/copilotOpportunity/assign.js

+      const updateCopilotOpportunity = async () => {
+        const transaction = await models.sequelize.transaction();
+        const memberDetails = await util.getMemberDetailsByUserIds([application.userId], req.log, req.id);
+        const member = memberDetails[0];


Ensure that memberDetails contains at least one element before accessing memberDetails[0] to prevent potential runtime errors.

github-actions · 2025-07-30T14:56:00Z

src/routes/copilotOpportunity/assign.js

+        const emailEventType = CONNECT_NOTIFICATION_EVENT.EXTERNAL_ACTION_EMAIL;
+        const copilotPortalUrl = config.get('copilotPortalUrl');
+        const requestData = copilotRequest.data;
+        createEvent(emailEventType, {


Consider adding error handling around the createEvent function to ensure that any issues with sending the email do not affect the transaction commit.

github-actions · 2025-07-30T14:56:00Z

src/routes/copilotOpportunity/assign.js

+            user_name: member ? member.handle : "",
+          },
+          sendgrid_template_id: TEMPLATE_IDS.COPILOT_ALREADY_PART_OF_PROJECT,
+          recipients: [member.email],


Ensure that member.email is validated or sanitized before being used as a recipient to prevent potential issues with invalid email addresses.

github-actions · 2025-07-30T14:56:03Z

src/routes/copilotOpportunity/assign.js

+        req.log.debug(`User already part of project: ${JSON.stringify(existingMember)}`);
+        if (['copilot', 'manager'].includes(existingMember.role)) {
+          req.log.debug(`User is a copilot or manager`);
+          await updateCopilotOpportunity();


The function updateCopilotOpportunity is now awaited, which implies it returns a promise. Ensure that the function is properly handling asynchronous operations and that any necessary error handling is in place for the promise resolution or rejection.

github-actions · 2025-07-30T14:56:06Z

src/routes/copilotOpportunity/assign.js

+            projectMember.get({ plain: true }),
+            existingMember);
+          req.log.debug(`Member updated in kafka`);
+          await updateCopilotOpportunity();


The function updateCopilotOpportunity() is now awaited. Ensure that this function returns a promise, otherwise the await keyword will not have the intended effect. If it does not return a promise, consider refactoring the function to do so.

github-actions · 2025-07-30T15:09:51Z

src/routes/copilotOpportunity/assign.js

+          status: COPILOT_APPLICATION_STATUS.CANCELED,
+        }, {
+          where: {
+            opportunityId: opportunity.id,


The removal of projectId from the where clause may affect the specificity of the query. Ensure that this change is intentional and that the query will still correctly identify the intended records without this condition.

github-actions · 2025-07-30T15:28:14Z

src/routes/copilotOpportunity/assign.js

-import { COPILOT_APPLICATION_STATUS, COPILOT_OPPORTUNITY_STATUS, COPILOT_REQUEST_STATUS, EVENT, INVITE_STATUS, PROJECT_MEMBER_ROLE, RESOURCES } from '../../constants';
+import { CONNECT_NOTIFICATION_EVENT, COPILOT_APPLICATION_STATUS, COPILOT_OPPORTUNITY_STATUS, COPILOT_REQUEST_STATUS, EVENT, INVITE_STATUS, PROJECT_MEMBER_ROLE, RESOURCES, TEMPLATE_IDS } from '../../constants';
+import { getCopilotTypeLabel } from '../../utils/copilot';
+import { createEvent } from '../../services/busApi';


The import statement for createEvent from ../../services/busApi is added, but it is not used in the current code. Consider removing it if it is not needed, or ensure it is utilized in the code changes.

github-actions · 2025-07-30T15:39:00Z

src/routes/projectMembers/update.js

@@ -263,7 +263,7 @@ module.exports = [
        projectMember = projectMember.get({ plain: true });
        projectMember = _.omit(projectMember, ['deletedAt']);

-        if (['observer', 'customer'].includes(updatedProps.role)) {
+        if (['observer', 'customer'].includes(previousValue.role)) {


The condition has been changed from checking updatedProps.role to previousValue.role. Ensure that this change aligns with the intended logic of the application. If the goal is to check the role before the update rather than after, this change is correct. Otherwise, it might lead to unintended behavior if the role is meant to be checked after the update.

github-actions · 2025-07-30T15:42:42Z

src/routes/copilotOpportunity/assign.js

+import { CONNECT_NOTIFICATION_EVENT, COPILOT_APPLICATION_STATUS, COPILOT_OPPORTUNITY_STATUS, COPILOT_REQUEST_STATUS, EVENT, INVITE_STATUS, PROJECT_MEMBER_ROLE, RESOURCES, TEMPLATE_IDS } from '../../constants';
+import { getCopilotTypeLabel } from '../../utils/copilot';
+import { createEvent } from '../../services/busApi';
+import moment from 'moment';


Consider using a more lightweight date library or native JavaScript Date methods if only basic date manipulation is required. The 'moment' library can significantly increase the bundle size.

github-actions · 2025-07-30T20:03:59Z

src/routes/projectMembers/update.js

-        if (['observer', 'customer'].includes(updatedProps.role)) {
-          await completeAllCopilotRequests(req, projectId, _transaction, _member);
+        if (['observer', 'customer'].includes(previousValue.role)) {
+          await completeAllCopilotRequests(req, projectId, _transaction, projectMember);


The variable _member was replaced with projectMember. Ensure that projectMember contains all necessary properties and data expected by the completeAllCopilotRequests function. Verify that this change aligns with the intended functionality and does not introduce any unintended side effects.

github-actions · 2025-07-30T20:07:21Z

src/routes/projectMembers/update.js

@@ -163,8 +163,6 @@ const completeAllCopilotRequests = async (req, projectId, _transaction, _member)

    req.log.debug(`Sent email to ${member.email}`);
  });
-
-  await _transaction.commit();
 };



The removal of _transaction.commit() may lead to uncommitted transactions if this function is intended to finalize database changes. Ensure that the transaction is committed elsewhere if this is intentional, or consider re-adding the commit statement to prevent potential data inconsistencies.

github-actions · 2025-07-30T20:09:37Z

src/routes/projectMembers/update.js

@@ -263,8 +261,8 @@ module.exports = [
        projectMember = projectMember.get({ plain: true });
        projectMember = _.omit(projectMember, ['deletedAt']);

-        if (['observer', 'customer'].includes(updatedProps.role)) {
-          await completeAllCopilotRequests(req, projectId, _transaction, _member);
+        if (['observer', 'customer'].includes(previousValue.role) && ['copilot', 'manager'].includes(updatedProps.role)) {


Consider checking if updatedProps.role is defined before using it in the condition to prevent potential runtime errors if updatedProps is undefined or does not have a role property.

added existing membership to the copilot application

683b3d6

github-actions bot reviewed Jul 30, 2025

View reviewed changes

added existing membership to the copilot application

f0a889f

github-actions bot reviewed Jul 30, 2025

View reviewed changes

added existing membership to the copilot application

4823330

github-actions bot reviewed Jul 30, 2025

View reviewed changes

added existing membership to the copilot application

26dc288

github-actions bot reviewed Jul 30, 2025

View reviewed changes

added existing membership to the copilot application

59c6077

github-actions bot reviewed Jul 30, 2025

View reviewed changes

added existing membership to the copilot application

2ba33ac

github-actions bot reviewed Jul 30, 2025

View reviewed changes

added existing membership to the copilot application

04b4e37

github-actions bot reviewed Jul 30, 2025

View reviewed changes

added existing membership to the copilot application

f2a8c89

github-actions bot reviewed Jul 30, 2025

View reviewed changes

added existing membership to the copilot application

76a22c1

github-actions bot reviewed Jul 30, 2025

View reviewed changes

added existing membership to the copilot application

cf120a8

github-actions bot reviewed Jul 30, 2025

View reviewed changes

hentrymartin added 2 commits July 30, 2025 15:04

added existing membership to the copilot application

471d5e1

added existing membership to the copilot application

1559e31

github-actions bot reviewed Jul 30, 2025

View reviewed changes

added existing membership to the copilot application

44ac842

github-actions bot reviewed Jul 30, 2025

View reviewed changes

added existing membership to the copilot application

de8c14f

github-actions bot reviewed Jul 30, 2025

View reviewed changes

added existing membership to the copilot application

40076d3

github-actions bot reviewed Jul 30, 2025

View reviewed changes

added existing membership to the copilot application

d40373d

github-actions bot reviewed Jul 30, 2025

View reviewed changes

added existing membership to the copilot application

8b2fa3e

github-actions bot reviewed Jul 30, 2025

View reviewed changes

added existing membership to the copilot application

e7a328b

github-actions bot reviewed Jul 30, 2025

View reviewed changes

added existing membership to the copilot application

ab268ca

github-actions bot reviewed Jul 30, 2025

View reviewed changes

added existing membership to the copilot application

e82e6b2

github-actions bot reviewed Jul 30, 2025

View reviewed changes

hentrymartin changed the title ~~[WIP] fix(PM-1510): added existing membership to the copilot application~~ fix(PM-1510): added existing membership to the copilot application Jul 30, 2025

fix: show already member modal

dad92bc

github-actions bot reviewed Jul 30, 2025

View reviewed changes

fix: show already member modal

ada10e8

github-actions bot reviewed Jul 30, 2025

View reviewed changes

fix: show already member modal

c2df9ee

github-actions bot reviewed Jul 30, 2025

View reviewed changes

hentrymartin merged commit 6122446 into develop Jul 30, 2025
2 checks passed

hentrymartin deleted the pm-1510 branch July 30, 2025 20:58

		@@ -31,19 +31,42 @@ module.exports = [
		canAccessAllApplications ? {} : { createdBy: userId },
		);

fix(PM-1510): added existing membership to the copilot application #840

fix(PM-1510): added existing membership to the copilot application #840

Uh oh!

Conversation

hentrymartin commented Jul 30, 2025

Uh oh!

github-actions bot Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 30, 2025

Choose a reason for hiding this comment