fix(PM-1398): cancel invites on canceling the copilot opportunity #844
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -54,6 +56,14 @@ module.exports = [ | |||
| })); | |||
| }); | |||
|
|
|||
| const allInvites = await models.ProjectMemberInvite.findAll({ | |||
There was a problem hiding this comment.
Consider adding error handling for the findAll operation to ensure that any issues with retrieving invites do not cause the entire operation to fail.
| const allInvites = await models.ProjectMemberInvite.findAll({ | ||
| where: { | ||
| applicationId: { | ||
| [Op.in]: applications.map(item => item.id), |
There was a problem hiding this comment.
Ensure that applications.map(item => item.id) returns a valid array of IDs. If applications is empty or undefined, this could lead to unexpected behavior. Consider adding a check or default value.
| // associated to the copilot opportunity | ||
| // with cancel status | ||
| for (const invite of allInvites) { | ||
| await invite.update({ |
There was a problem hiding this comment.
Consider adding error handling for the invite.update operation to ensure that any issues during the update process are caught and managed appropriately.
| await invite.update({ | ||
| status: INVITE_STATUS.CANCELED, | ||
| }); | ||
| await invite.reload(); |
There was a problem hiding this comment.
The invite.reload() operation might not be necessary if the invite.update operation already returns the updated instance. Consider checking if this step can be optimized or removed.
| status: INVITE_STATUS.CANCELED, | ||
| }); | ||
| await invite.reload(); | ||
| util.sendResourceToKafkaBus( |
There was a problem hiding this comment.
Consider adding error handling for the util.sendResourceToKafkaBus function to ensure that any issues with sending the message to the Kafka bus are caught and managed appropriately.
What's in this PR?