Skip to content

fix(PM-2435): identity service response structure #860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 22, 2025
Merged

fix(PM-2435): identity service response structure #860

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0160645
debug email notifications
hentrymartin Oct 20, 2025
75ca73d
debug email notifications
hentrymartin Oct 20, 2025
c3626b8
debug email notifications
hentrymartin Oct 20, 2025
3ac9e52
debug email notifications
hentrymartin Oct 20, 2025
3df6527
fix: removed debug logs
hentrymartin Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ workflows:
context : org-global
filters:
branches:
only: ['develop', 'migration-setup', 'PM-1612', 'fix-2321']
only: ['develop', 'migration-setup', 'PM-1612', 'fix-2321', 'pm-2435']
- deployProd:
context : org-global
filters:
Expand Down
2 changes: 1 addition & 1 deletion src/util.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -855,7 +855,7 @@ const projectServiceUtils = {
}).then((res) => {
const roles = res.data;
logger.debug(`Roles by ${roleName}: ${JSON.stringify(roles)}`);
return roles
return roles.result.content
Copy link

@github-actions github-actions bot Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[❗❗ correctness]
Ensure that roles.result.content is always defined and has the expected structure before accessing it. Consider adding a check to handle cases where result or content might be undefined, which could lead to runtime errors.

.filter(item => item.roleName === roleName)
.map(r => r.id);
});
Expand Down