Skip to content

Allows page and perPage parameters at services/challenges.js#getUserResources #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 31, 2020
Merged

Allows page and perPage parameters at services/challenges.js#getUserResources #232

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cf892ff
fix(challenge-utils): update `filterByUsers` to use `userId`
cagdas001 Aug 23, 2020
02fd5ed
Revert "fix(challenge-utils): update `filterByUsers` to use `userId`"
cagdas001 Aug 27, 2020
385538f
fix: add `page` and `perPage` parameters in `getUserResources`
cagdas001 Aug 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/services/challenges.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -522,10 +522,12 @@ class ChallengesService {
/**
* Gets user resources.
* @param {String} userId User id whose challenges we want to fetch.
* @param {Number} page Current page for paginated API response (default 1)
* @param {Number} perPage Page size for paginated API response (default 1000)
* @return {Promise} Resolves to the api response.
*/
async getUserResources(userId) {
const res = await this.private.apiV5.get(`/resources/${userId}/challenges`);
async getUserResources(userId, page = 1, perPage = 1000) {
const res = await this.private.apiV5.get(`/resources/${userId}/challenges?page=${page}&perPage=${perPage}`);
return res.json();
}

Expand Down