Skip to content

Fix Review Opportunities QA filter #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 31, 2020
Merged

Fix Review Opportunities QA filter #238

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3aa228e
Fix Review Opportunities QA filter
luizrrodrigues Aug 31, 2020
c1cb920
Fix snapshot
luizrrodrigues Aug 31, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions __tests__/__snapshots__/index.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,6 +385,8 @@ Object {
},
"OLD_SUBTRACKS": Object {
"BUG_HUNT": "BUG_HUNT",
"TESTING_COMPETITION": "TESTING_COMPETITION",
"TEST_SCENARIOS": "TEST_SCENARIOS",
"TEST_SUITES": "TEST_SUITES",
},
"REVIEW_OPPORTUNITY_TYPES": Object {
Expand Down
6 changes: 3 additions & 3 deletions src/services/reviewOpportunities.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,11 @@ export function normalizeChallenges(opportunities) {
if (challenge.technologies) {
if (challenge.technologies.includes(COMPETITION_TRACKS.DATA_SCIENCE)) {
challenge.track = COMPETITION_TRACKS.DATA_SCIENCE;
} else if (challenge.technologies.includes(OLD_COMPETITION_TRACKS.QA)) {
challenge.track = COMPETITION_TRACKS.QA;
}
} else if (challenge.subTrack === OLD_SUBTRACKS.TEST_SUITES
|| challenge.subTrack === OLD_SUBTRACKS.BUG_HUNT) {
|| challenge.subTrack === OLD_SUBTRACKS.BUG_HUNT
|| challenge.subTrack === OLD_COMPETITION_TRACKS.TEST_SCENARIOS
|| challenge.subTrack === OLD_COMPETITION_TRACKS.TESTING_COMPETITION) {
challenge.track = COMPETITION_TRACKS.QA;
} else if (challenge.track === OLD_COMPETITION_TRACKS.DESIGN) {
challenge.track = COMPETITION_TRACKS.DESIGN;
Expand Down
2 changes: 2 additions & 0 deletions src/utils/tc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@ export const OLD_COMPETITION_TRACKS = {
export const OLD_SUBTRACKS = {
TEST_SUITES: 'TEST_SUITES',
BUG_HUNT: 'BUG_HUNT',
TEST_SCENARIOS: 'TEST_SCENARIOS',
TESTING_COMPETITION: 'TESTING_COMPETITION',
};

/**
Expand Down