[$50] No Iterative Reviewer set on F2F

[jmgasper]

Expected behavior

• Launched a F2F
• Selected review type as "internal"
• Selected myself as the copilot

Expected - My account would be set as the Iterative Reviewer

Actual behavior

No reviewer was set, so notifications weren't sent on submission, and the review timeline didn't open.

[drasticdpk]

@vikasrohit ,
Observer Role is showing instead of Iterative Reviewer.

Fro Development and other track is working as expected.

[acshields]

@rootelement @maxceem - Is this a frontend or backend/API update that is needed?

[rootelement]

Work Manager needs to add the selected reviewer as an iterative reviewer resource. I just added myself as one through admin.topcoder.com and it propagated to OR correctly, so this is not an API issue

[vikasrohit]

@rootelement we are already adding the internal reviewer selected by the user as Reviewer resource. Do we need to add the same user as Iterative Reviewer resource as well? If yes, it should be done only for F2Fs or any other challenge type needs this treatment as well?

[vikasrohit]

@maxceem lets add Iterative Reviewer instead of Reviewer role resource for F2Fs of all tracks https://github.com/topcoder-platform/work-manager/blob/develop/src/components/ChallengeEditor/index.js#L968.

[maxceem]

Sum up:

• When we run First2Finish type of challenge

  

• Then when we select Internal Review and choose the reviewer, it should be added using Iterative Reviewer role instead of Reviewer :

  

[maxceem]

@vikasrohit I have some difficulties with testing this.

If I create a challenge type "Challenge" or "F2F" and assigned myself as an internal reviewer. In Online Review I don't have any reviewer role, only Observer.

There are example challenges:

• F2F https://challenges.topcoder-dev.com/projects/16668/challenges/4cd149d5-8444-47e9-86f7-12e50ad0a6ce/view
• Challenge https://challenges.topcoder-dev.com/projects/16668/challenges/ed2c75a5-921e-4c8b-95d0-0a29817d0a59/view

Note, that at the moment user is not shown as assigned reviewer because resources API always return 0 resources due to some issue in Resource API topcoder-platform/resources-api#56. But resource has been created.

[vikasrohit]

That is strange @maxceem. WM is adding the user as Reviewer https://github.com/topcoder-platform/work-manager/blob/develop/src/components/ChallengeEditor/index.js#L968. So, as you suggested it might be issue with the resource api if it is not adding any Reviewer resource to the legacy OR may be legacy apps has some business rules which is preventing the Reviewer to be added to the challenge.
@lakshmiathreya @drasticdpk @codejamtc do we have the test case for validating the reviewer addition, if yes was it working fine after our ES release?

[drasticdpk]

@vikasrohit ,
Unfortunately we have not included those scenario on our test case. Will put it for future uses.

[rootelement]

@ThomasKranitsas tested. WM is adding a Reviewer, not an Iterative Reviewer. Reviewer type is not valid for a F2F/Task. Please update the type for a task to be Iterative Reviewer uuid f6df7212-b9d6-4193-bfb1-b383586fce63

[ThomasKranitsas]

The APIs work fine. The WM needs to create an Iterative Reviewer resource for F2F/Tasks. As soon as I did that via Postman, the iterative reviewer role was added in legacy just fine

[vikasrohit]

@maxceem lets add Iterative Reviewer for F2F and Tasks if user choose Internal Review. Let me know if we have still some queries.

[nursoltan-s]

@bug-bash-helper assign

[bug-bash-hunt-helper]

@nursoltan-s 🛑 you have some issues assigned which are not completed yet, see #874.

As per our Bug Bash rules you may work only at one issue at a time.
Please, complete other issues first or unassign yourself before picking up a new issue.

[kodar007]

@bug-bash-helper assign

[maxceem]

@kodar007, could you please log in to the https://x.topcoder.com/ with your Topcoder account in incognito mode (it's important, please, use incognito mode) and associate your Topcoder account _ckd with your GitHub account kodar007 if you didn't do that previously.

[kodar007]

@maxceem Could you please try adding manually? My other topcoder account is getting deactivated.

[maxceem]

@maxceem Could you please try adding manually? My other topcoder account is getting deactivated.

@kodar007 I can do that, but did you try to associate your new account with your GitHub account via https://x.topcoder.com/ as described in this comment? #1008 (comment)

[kodar007]

Not done yet, i want to associate _ckd topcoder account with a different Github account so that tc account and github accounts have same email.

[maxceem]

Ah, ok, got you. So I will process this payment manually then.

[kodar007]

Thanks.

[maxceem]

@kodar007 payment is processed https://www.topcoder.com/challenges/38aadfb8-02da-4be6-95ad-6cc0b975c4dd?tab=details

[maxceem]

This ticket was not processed for payment. If you would like to process it for payment, please reopen it, add the tcx_FixAccepted label, and then close it again

This is an automated message for maxceem via Topcoder X