Skip to content

[$50] Groups Filter #1013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rootelement opened this issue Dec 21, 2020 · 22 comments
Closed

[$50] Groups Filter #1013

rootelement opened this issue Dec 21, 2020 · 22 comments

Comments

@rootelement
Copy link
Contributor

Groups API added Fuzzy Filter for search by name:
https://api.topcoder.com/v5/groups?name=TCO

I recommend using this on the Groups field to make it easier to find the group for a challenge

@acshields
Copy link

@rootelement - will this be something that's on your plate, or Vikas? And if it's yours, is it already in motion? Just going through logged issues to understand priority/ownership :)

@rootelement
Copy link
Contributor Author

rootelement commented Dec 22, 2020 via email

@acshields
Copy link

@maxceem - is this something that you can get implemented?

@maxceem
Copy link
Contributor

maxceem commented Jan 6, 2021

@vikasrohit could you help me confirm a few moments.

  1. At the moment we are showing all the groups by default, should we still show all of them, or don't show any without typing any filter?

    image

  2. We already have a filter implemented client-side, as I understand the task is to replace it with server-side filter, because server-side filter is smarter and supports fuzzy searching.

@maxceem maxceem added the Have A Question (Dev) Developer asked some question to copilot/manager. label Jan 6, 2021
@vikasrohit
Copy link

  1. Yes, please don't show any group by default and update the text Select Groups to Search Groups
  2. You are right. It would avoid troubles with admin users who have access to too many groups that it can either fail the API request which fetches the groups or can delay the overall page load.

@maxceem maxceem removed the Have A Question (Dev) Developer asked some question to copilot/manager. label Jan 6, 2021
@maxceem maxceem changed the title Groups Filter [$50] Groups Filter Jan 6, 2021
@maxceem
Copy link
Contributor

maxceem commented Jan 6, 2021

Sum up:

  • If the lib we are using for showing the dropdown list supports server-side filtering, then reuse that build-in functionality.

@maxceem maxceem added the CF Issue for Community Fixes in the current Bug Bash label Jan 8, 2021
@maxceem maxceem removed their assignment Jan 8, 2021
@CDharmateja
Copy link
Contributor

@bug-bash-helper assign

@bug-bash-hunt-helper
Copy link

@CDharmateja ✅ you are now assigned to this issue and have 12 hours to complete it.

As soon as you are done, please, make a comment like below, including the link to the pull request:

@bug-bash-helper <link to PR> is ready for review

@CDharmateja
Copy link
Contributor

@bug-bash-helper #1032 is ready for review

@bug-bash-hunt-helper
Copy link

@CDharmateja ✅ this issue is marked as Ready for Review.

Now you may pick up another issue which is open for pickup if you like to.

@maxceem
Copy link
Contributor

maxceem commented Jan 12, 2021

hi @CDharmateja here is the feedback for your PR #1032 (review)

@maxceem
Copy link
Contributor

maxceem commented Jan 19, 2021

Contest https://www.topcoder.com/challenges/30162862 has been created for this ticket.

This is an automated message for maxceem via Topcoder X

@maxceem
Copy link
Contributor

maxceem commented Jan 19, 2021

Contest https://www.topcoder.com/challenges/30162862 has been updated - it has been assigned to cdharmateja.

This is an automated message for maxceem via Topcoder X

@maxceem
Copy link
Contributor

maxceem commented Jan 19, 2021

Payment failed: [500]: Failed to get challenge details by Id

This is an automated message for maxceem via Topcoder X

@maxceem
Copy link
Contributor

maxceem commented Jan 20, 2021

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30162862

This is an automated message for maxceem via Topcoder X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants