Skip to content

[$80] Delete Capability: Items in "New" Status #927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
acshields opened this issue Dec 3, 2020 · 23 comments
Closed

[$80] Delete Capability: Items in "New" Status #927

acshields opened this issue Dec 3, 2020 · 23 comments

Comments

@acshields
Copy link

If an item (challenge, task, F2F) is in "New" status, the user should have the capability to delete it.

  • On the "all items" view for the project, items in "New" status should display a delete button.
  • If the user clicks into the item (i.e. the set-up screens), at the bottom they should see a "Delete" button.
@maxceem
Copy link
Contributor

maxceem commented Jan 6, 2021

@vikasrohit I'm suggesting showing a standard browser confirmation window for this action instead of custom dialogs. Because our current implementation of dialogs requires a lot of code to write.

@maxceem
Copy link
Contributor

maxceem commented Jan 6, 2021

Sum up:

  • Add red "Delete" button in the challenge list, but only for new challenges.

    image

  • It should be only shown on hover similar to "Active" button for Draft challenges.

  • When we click "Delete" show a confirmation dialog similar to when we click "Acitve"

    image

    It should work similar to when we activate:

    • if we confirm, show "processing"
    • show red error if error happens during API request. we should be able to click "Confirm" again and try deleting again.
    • when successful close dialog and remove challenge form the list without list reloading
  • We also have to show "Delete" button on the challenge editing page

    image

  • When we click it, show a confirmation modal, same like on the list.

  • As soon as challenge is deleted redirect to challenge list page.

  • When we delete challenge successfully from any place show a green "toastr" message: "Challenge deleted successfully".

@maxceem maxceem changed the title Delete Capability: Items in "New" Status [$80] Delete Capability: Items in "New" Status Jan 6, 2021
@maxceem maxceem added the Have A Question (Dev) Developer asked some question to copilot/manager. label Jan 6, 2021
@vikasrohit
Copy link

I'm suggesting showing a standard browser confirmation window for this action instead of custom dialogs. Because our current implementation of dialogs requires a lot of code to write.

We already modal implementations in place @maxceem, you can reuse them. We are showing such modal confirmations for Activation of challenge as well. Lets keep the UX same for this feature as well.

@maxceem maxceem added the CF Issue for Community Fixes in the current Bug Bash label Jan 8, 2021
@maxceem maxceem removed their assignment Jan 8, 2021
@mark-nakachon
Copy link
Contributor

@bug-bash-helper assign

@bug-bash-hunt-helper
Copy link

@mark-nakachon 🛑 this issue is not open for pick up.

You may only pickup issues which are included in this Bug Bash and open for pick up.
Such issues have open status and have labels CF and Open for Pickup.

@maxceem maxceem removed Have A Question (Dev) Developer asked some question to copilot/manager. Open for Pickup labels Jan 9, 2021
@maxceem
Copy link
Contributor

maxceem commented Jan 9, 2021

@mark-nakachon assigned

mark-nakachon added a commit to mark-nakachon/work-manager that referenced this issue Jan 9, 2021
@mark-nakachon
Copy link
Contributor

@bug-bash-helper #1030 is ready for review

@bug-bash-hunt-helper
Copy link

@mark-nakachon ✅ this issue is marked as Ready for Review.

Now you may pick up another issue which is open for pickup if you like to.

@maxceem maxceem added Feedback The issue hasn't been fixed completely and some feedback has been provided. and removed Ready for Review labels Jan 11, 2021
maxceem added a commit that referenced this issue Jan 11, 2021
@maxceem maxceem closed this as completed Jan 19, 2021
@maxceem
Copy link
Contributor

maxceem commented Jan 19, 2021

Payment failed: [500]: Failed to get billing detail for the project.

This is an automated message for maxceem via Topcoder X

@maxceem
Copy link
Contributor

maxceem commented Jan 20, 2021

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30162863

This is an automated message for maxceem via Topcoder X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants