Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Negative Mode and Charge Carriers #114

Merged
merged 4 commits into from
Apr 15, 2024
Merged

Negative Mode and Charge Carriers #114

merged 4 commits into from
Apr 15, 2024

Conversation

rfellers
Copy link
Member

adds better support for negative charges and custom charge carriers for Mercury7

@codecov Codecov
Copy link

codecov bot commented Apr 10, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 88.88889% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 89.08%. Comparing base (fb4b105) to head (9c8b3ae).
Report is 14 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #114      +/-   ##
==========================================
+ Coverage   85.00%   89.08%   +4.07%     
==========================================
  Files         102      103       +1     
  Lines        5549     5697     +148     
  Branches      858      878      +20     
==========================================
+ Hits         4717     5075     +358     
+ Misses        672      457     -215     
- Partials      160      165       +5
Files Coverage Δ
...cs/MassSpectrometry/ChargedIsotopicDistribution.cs 65.62% <80.00%> (+5.62%) ⬆️
src/TopDownProteomics/Utility.cs 65.78% <88.88%> (-0.88%) ⬇️
...roteomics/MassSpectrometry/IsotopicDistribution.cs 50.00% <58.33%> (-12.97%) ⬇️
src/TopDownProteomics/Tools/Mercury7.cs 93.02% <92.37%> (-0.51%) ⬇️

... and 2 files with indirect coverage changes

@rfellers rfellers marked this pull request as draft April 10, 2024 17:09
@rfellers
keep track of the charge carrier on the charged isotopic distribution…
c7e2e8b 
…s that are created, utility OrderPair() method
@rfellers rfellers marked this pull request as ready for review April 10, 2024 18:18
@rfellers rfellers requested a review from b-early April 12, 2024 13:28
mikehollas123
mikehollas123 approved these changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@mikehollas123 mikehollas123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!

@rfellers rfellers merged commit eba0adb into master Apr 15, 2024
3 checks passed
@rfellers rfellers deleted the ryan/negMode-chargeCarrier branch April 15, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joseph-greer joseph-greer joseph-greer approved these changes

@mikehollas123 mikehollas123 mikehollas123 approved these changes

@b-early b-early Awaiting requested review from b-early

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rfellers @joseph-greer @mikehollas123