Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(room_manager): only sort rooms removal if major version diff #640

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

hspedro
Copy link
Collaborator

@hspedro hspedro commented Oct 8, 2024

We only want to apply sorting by version if the room has a major version of difference compared to the active scheduler version. This prevents minor updates forcing the sort, which would cause occupied rooms to be deleted first (from a prior minor version) when we don't want that behavior. Thus, check if it has a major version diff between room and active scheduler

We only want to apply sorting by version if the room has a major version of
difference compared to the active scheduler version. This prevents minor
updates forcing the sort, which would cause occupied rooms to be deleted
first (from a prior minor version) when we don't want that behavior. Thus,
check if it has a major version diff between room and active scheduler
@hspedro hspedro force-pushed the fix/do-no-sort-deletion-minor-version branch from 57f54aa to 9ae55f4 Compare October 9, 2024 12:43
@hspedro hspedro merged commit dd58d08 into main Oct 9, 2024
17 checks passed
@hspedro hspedro deleted the fix/do-no-sort-deletion-minor-version branch October 9, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants