This repository has been archived by the owner on Sep 11, 2023. It is now read-only.
Update Pitaya version & misc improvements #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Error was the following: go: github.com/topfreegames/pitaya@v0.14.3 requires github.com/jhump/protoreflect@v0.0.0-20181126200011-b5ebaabe89bf requires google.golang.org/genproto@v0.0.0-20170818100345-ee236bd376b0: invalid pseudo-version: does not match version-control timestamp (2017-08-18T01:03:45Z)
Also removes TLS option, the client will try to connect in every way until it succedes.
In some cases where the spec couldn't finish this failure wouldn't be logged at all
To match Request behaviour so we can also build a NewExpectError
henrod
reviewed
Apr 1, 2021
|
LGTM! |
|
Thanks! No write access here, can you merge? |
henriqueoelze
approved these changes
Nov 3, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main updates are: