Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge #350

Open
wants to merge 33 commits into
base: main
Choose a base branch
from
Open

Merge #350

wants to merge 33 commits into from

Conversation

urionz
Copy link
Contributor

@urionz urionz commented Oct 9, 2023

Merge

Copy link
Contributor

@felipejfc felipejfc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx for your PR @urionz. we should add the new configuration variables in the docs here: https://github.com/topfreegames/pitaya/blob/main/docs/configuration.rst

EDIT: I believe Unit tests also broken with the changes. Plz fiz them

@coveralls
Copy link

coveralls commented Mar 4, 2024

Pull Request Test Coverage Report for Build 8385648936

Details

  • 39 of 70 (55.71%) changed or added relevant lines in 9 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.05%) to 62.029%

Changes Missing Coverage Covered Lines Changed/Added Lines %
agent/agent.go 8 9 88.89%
app.go 0 1 0.0%
groups/etcd_group_service.go 0 2 0.0%
modules/binding_storage.go 0 4 0.0%
cluster/etcd_service_discovery.go 0 9 0.0%
acceptor/ws_acceptor.go 17 31 54.84%
Files with Coverage Reduction New Missed Lines %
acceptor/ws_acceptor.go 1 74.86%
modules/binary.go 2 73.91%
Totals Coverage Status
Change from base Build 8010529527: -0.05%
Covered Lines: 4842
Relevant Lines: 7806

💛 - Coveralls

@felipejfc
Copy link
Contributor

Unit tests are failing. Can you take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants