Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/observability gaps #406

Merged
merged 22 commits into from
Jun 25, 2024
Merged

Fix/observability gaps #406

merged 22 commits into from
Jun 25, 2024

Conversation

renatoaf
Copy link
Member

  • Add tracing span for connection writes (we're noticing some high times in some of our games, we might want to add a timeout here in the future)
  • Properly wrap errors when low-level connection writes fail (they are currently failing with a PIT-000 code in the metrics)
  • Add error logging on some spots we were previously missing

@felipejfc
Copy link
Contributor

@renatoaf idk if it was with these changes, but the unit tests are failing, I've already re-ran they 3 times but no luck. can you check before merging?

@coveralls
Copy link

coveralls commented Jun 25, 2024

Pull Request Test Coverage Report for Build 9668461825

Details

  • 44 of 53 (83.02%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 61.991%

Changes Missing Coverage Covered Lines Changed/Added Lines %
agent/agent.go 41 43 95.35%
cluster/nats_rpc_server.go 2 4 50.0%
service/handler.go 0 5 0.0%
Totals Coverage Status
Change from base Build 8848487306: 0.2%
Covered Lines: 4875
Relevant Lines: 7864

💛 - Coveralls

@renatoaf
Copy link
Member Author

@renatoaf idk if it was with these changes, but the unit tests are failing, I've already re-ran they 3 times but no luck. can you check before merging?

Yep. Fixed the test and added a new one covering this scenario (closed agent after a write fails)

@coveralls
Copy link

coveralls commented Jun 25, 2024

Pull Request Test Coverage Report for Build 9668735601

Details

  • 44 of 53 (83.02%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 61.991%

Changes Missing Coverage Covered Lines Changed/Added Lines %
agent/agent.go 41 43 95.35%
cluster/nats_rpc_server.go 2 4 50.0%
service/handler.go 0 5 0.0%
Totals Coverage Status
Change from base Build 8848487306: 0.2%
Covered Lines: 4875
Relevant Lines: 7864

💛 - Coveralls

@felipejfc felipejfc merged commit 11965de into main Jun 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants