feat(agent): add timeout on write calls #426
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hspedro
force-pushed
the
feat/agent-write-timeout
branch
2 times, most recently
from
0803937 to
7d97542
Compare
hspedro
force-pushed
the
feat/agent-write-timeout
branch
2 times, most recently
from
3ef3eff to
930a149
Compare
When sending a message via agent, the write connection does not have a default timeout, leading to blocking calls if the connections is unhealthy or simply a bad route to it. Thus, adding a write timeout to the writes so we fail but don't block. If deadline is exceeded then we log an error but don't close a connection, since it might fail due to bad route but not a broken pipe per-se. The new configuration can be found under: `pitaya.buffer.agent.writetimeout`, with 10s by deafult. The timeout is set using `SetWriteDeadline` function from go net pkg: https://pkg.go.dev/net#Conn
hspedro
force-pushed
the
feat/agent-write-timeout
branch
from
930a149 to
74298ad
Compare
hspedro
force-pushed
the
feat/agent-write-timeout
branch
from
7717e22 to
0f28ff2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When sending a message via agent, the write connection does not have a default timeout, leading to blocking calls if the connections is unhealthy or simply a bad route to it. Thus, adding a write timeout to the writes so we fail but don't block. If deadline is exceeded then we log an error but don't close a connection, since it might fail due to bad route but not a broken pipe per-se. The new configuration can be found under:
pitaya.buffer.agent.writetimeout, with 10s by default.The timeout is set using
SetWriteDeadlinefunction from go net pkg: https://pkg.go.dev/net#Conn