Fix wrong cxx_extern return value #8294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix UB
yujincheng08
commented
Aug 7, 2024
| bool mv_path(const char *src, const char *dest); | ||
| bool link_path(const char *src, const char *dest); | ||
| bool clone_attr(const char *src, const char *dest); | ||
| bool fclone_attr(int src, int dest); |
There was a problem hiding this comment.
Magisk/native/src/base/cxx_extern.rs
Line 174 in 07835a3
yujincheng08
commented
Aug 7, 2024
| bool cp_afc(const char *src, const char *dest); | ||
| bool mv_path(const char *src, const char *dest); | ||
| bool link_path(const char *src, const char *dest); | ||
| bool clone_attr(const char *src, const char *dest); |
There was a problem hiding this comment.
Magisk/native/src/base/cxx_extern.rs
Line 158 in 07835a3
yujincheng08
commented
Aug 7, 2024
| void fclone_attr(int src, int dest); | ||
| bool cp_afc(const char *src, const char *dest); | ||
| bool mv_path(const char *src, const char *dest); | ||
| bool link_path(const char *src, const char *dest); |
There was a problem hiding this comment.
Magisk/native/src/base/cxx_extern.rs
Line 141 in 07835a3
yujincheng08
commented
Aug 7, 2024
| void clone_attr(const char *src, const char *dest); | ||
| void fclone_attr(int src, int dest); | ||
| bool cp_afc(const char *src, const char *dest); | ||
| bool mv_path(const char *src, const char *dest); |
There was a problem hiding this comment.
Magisk/native/src/base/cxx_extern.rs
Line 124 in 07835a3
yujincheng08
commented
Aug 7, 2024
| void link_path(const char *src, const char *dest); | ||
| void clone_attr(const char *src, const char *dest); | ||
| void fclone_attr(int src, int dest); | ||
| bool cp_afc(const char *src, const char *dest); |
There was a problem hiding this comment.
Magisk/native/src/base/cxx_extern.rs
Line 107 in 07835a3
topjohnwu
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.