Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Lidl_cz BF): #2657 - lidl.cz - replace sleep() with new Promise #2659

Merged
merged 1 commit into from
Nov 29, 2024
Merged

fix(Lidl_cz BF): #2657 - lidl.cz - replace sleep() with new Promise #2659

merged 1 commit into from
Nov 29, 2024

Conversation

oleksandravalko
Copy link
Contributor

No description provided.

@rarous
Copy link
Collaborator

rarous commented Nov 28, 2024

sleep and page.waitForLoadState("networkidle") shouldn't be used. It's race condition and discouraged way of handling things. The code should await some locator, that indicates the data is loaded.

@rarous rarous merged commit f3f7f68 into topmonks:trunk Nov 29, 2024
@oleksandravalko oleksandravalko deleted the fix/lidl.cz-sleep branch January 31, 2025 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oleksandravalko @rarous