Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make stitchedArcs a Set. #35

Open
martinfrances107 opened this issue Aug 21, 2022 · 0 comments
Open

Make stitchedArcs a Set. #35

martinfrances107 opened this issue Aug 21, 2022 · 0 comments

Comments

@martinfrances107
Copy link

I have a minor nudge.

var stitchedArcs = {}

Looking at the life-cycle of the object stitchedArcs

It has the characteristics of a set ( i.e. a [key,value] pairs where the value is only ever set to '1' )

I would like to make this semantically more precise.

By semantically I mean I want to, lock this down, to give assurances that the value is never accidentally incremented or set to a a value like as 'socks'.

I am about to submit a three line PR

martinfrances107 added a commit to martinfrances107/topojson-client that referenced this issue Aug 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant