feat: enable PX #363
Open
feat: enable PX #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfroment
force-pushed
the
feat/enable-PX
branch
from
f7d915a to
4c5dadc
Compare
d-roak
reviewed
Jan 15, 2025
| @@ -216,6 +216,13 @@ async function main() { | |||
| render(); | |||
| }); | |||
|
|
|||
| setInterval(() => { | |||
| peers = node.networkNode.getAllPeers(); | |||
| discoveryPeers = node.networkNode.getGroupPeers("drp::discovery"); | |||
There was a problem hiding this comment.
let's drop the listing of discoveryPeers on the examples (all)
There was a problem hiding this comment.
why not? is it useful information?
| IPColocationFactorWeight: 0, | ||
| appSpecificScore: (peerId: string) => { | ||
| if (_bootstrapPeerID.includes(peerId)) { |
There was a problem hiding this comment.
why are we creating a new variable and populating it instead of directly checking _bootstrapNodesList?
There was a problem hiding this comment.
There the list is only the list of the peer id in the BT list not the full MA.
This is made in order not to recompute the same variable over and over
There was a problem hiding this comment.
Suggested change
| if (_bootstrapPeerID.includes(peerId)) { | |
| if (_bootstrapNodesList.some((addr) => addr.includes(peerId))) { |
how pre-populating is better than this? you don't recompute, it's only computed when you do the initialization (no?)
| }, | ||
| }), | ||
| scoreThresholds: createPeerScoreThresholds({ | ||
| gossipThreshold: -50, |
Signed-off-by: Sacha Froment <sfroment42@gmail.com>
Signed-off-by: Sacha Froment <sfroment42@gmail.com>
Signed-off-by: Sacha Froment <sfroment42@gmail.com>
Signed-off-by: Sacha Froment <sfroment42@gmail.com>
Signed-off-by: Sacha Froment <sfroment42@gmail.com>
sfroment
force-pushed
the
feat/enable-PX
branch
from
9102b3a to
537c455
Compare
Signed-off-by: Sacha Froment <sfroment42@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sacha Froment sfroment42@gmail.com