Skip to content
This repository has been archived by the owner on Oct 31, 2024. It is now read-only.

feat: adding testable docker behavior #109

Merged
merged 9 commits into from
Jan 18, 2023
Merged

Conversation

Freyskeyd
Copy link
Member

@Freyskeyd Freyskeyd commented Jan 5, 2023

Description

This PR allows the docker setup to automatically publish PeerId of TCE node into a shared file in order to trigger the push of this list to each gatekeeper.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
    • Add the NetworkClient to the synchronizer
  • New feature (non-breaking change which adds functionality) TP-386
    • Add an init.sh that replace the entrypoint of the docker image @toposware/tools

How Has This Been Tested?

  • Building the image, running it on a local macbook pro with 5 peers, 1 boot node
  • Cert spammer seems to keep pushing certs but the delivery doesn't seems to occure, it misses the part where each tce node receives an update for the gatekeeper.

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added or updated tests that comprehensively prove my change is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Signed-off-by: Freyskeyd simon.paitrault@gmail.com

@Freyskeyd Freyskeyd force-pushed the feature/init-sh-dockerfile branch 5 times, most recently from 1f6e548 to 52577ca Compare January 5, 2023 17:01
@Freyskeyd Freyskeyd marked this pull request as ready for review January 5, 2023 17:16
@Freyskeyd Freyskeyd requested a review from a team as a code owner January 5, 2023 17:16
@Freyskeyd Freyskeyd requested review from atanmarko and JDawg287 and removed request for a team January 5, 2023 17:16
@codecov
Copy link

codecov bot commented Jan 5, 2023

Codecov Report

Base: 38.31% // Head: 38.55% // Increases project coverage by +0.23% 🎉

Coverage data is based on head (c314e42) compared to base (9cc93c1).
Patch coverage: 32.03% of modified lines in pull request are covered.

❗ Current head c314e42 differs from pull request most recent head e9a11b4. Consider uploading reports for the commit e9a11b4 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #109      +/-   ##
==========================================
+ Coverage   38.31%   38.55%   +0.23%     
==========================================
  Files          81       83       +2     
  Lines        3583     3963     +380     
==========================================
+ Hits         1373     1528     +155     
- Misses       2210     2435     +225     
Impacted Files Coverage Δ
crates/topos-api/src/generated/topos.tce.v1.rs 34.80% <0.00%> (-5.86%) ⬇️
crates/topos-p2p/src/behaviour/discovery.rs 88.23% <ø> (+68.23%) ⬆️
crates/topos-p2p/src/runtime/handle_command.rs 74.62% <ø> (+53.19%) ⬆️
...ncer-subnet-runtime-proxy/tests/subnet_contract.rs 0.00% <ø> (ø)
crates/topos-tce-api/src/grpc/console.rs 0.00% <0.00%> (ø)
crates/topos-tce-api/src/grpc/mod.rs 29.54% <0.00%> (-8.69%) ⬇️
crates/topos-tce-api/src/metadata_map.rs 0.00% <0.00%> (ø)
crates/topos-tce-api/src/runtime/client.rs 50.00% <0.00%> (-21.43%) ⬇️
crates/topos-tce-api/src/runtime/mod.rs 53.57% <0.00%> (-4.88%) ⬇️
crates/topos-tce-api/src/stream/mod.rs 74.54% <ø> (+4.27%) ⬆️
... and 32 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

crates/topos-p2p/src/lib.rs Show resolved Hide resolved
crates/topos/tests/tce.rs Outdated Show resolved Hide resolved
@Freyskeyd Freyskeyd force-pushed the feature/init-sh-dockerfile branch 3 times, most recently from b842718 to 9812af1 Compare January 11, 2023 14:25
@Freyskeyd Freyskeyd force-pushed the feature/init-sh-dockerfile branch 4 times, most recently from e27287a to 225ab54 Compare January 17, 2023 10:24
Signed-off-by: Freyskeyd <simon.paitrault@gmail.com>
Signed-off-by: Freyskeyd <simon.paitrault@gmail.com>
Signed-off-by: Freyskeyd <simon.paitrault@gmail.com>
Signed-off-by: Freyskeyd <simon.paitrault@gmail.com>
Signed-off-by: Freyskeyd <simon.paitrault@gmail.com>
Signed-off-by: Freyskeyd <simon.paitrault@gmail.com>
Signed-off-by: Freyskeyd <simon.paitrault@gmail.com>
Signed-off-by: Freyskeyd <simon.paitrault@gmail.com>
Signed-off-by: Freyskeyd <simon.paitrault@gmail.com>
@Freyskeyd Freyskeyd merged commit 39cdbbc into main Jan 18, 2023
@Freyskeyd Freyskeyd deleted the feature/init-sh-dockerfile branch January 18, 2023 16:23
@sebastiendan sebastiendan mentioned this pull request Jan 24, 2023
8 tasks
hadjiszs pushed a commit that referenced this pull request Mar 9, 2023
hadjiszs pushed a commit that referenced this pull request Mar 9, 2023
hadjiszs pushed a commit that referenced this pull request Mar 9, 2023
hadjiszs pushed a commit that referenced this pull request Mar 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants