This repository has been archived by the owner on Oct 31, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5
feat: add push certificate instrumentation event #195
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atanmarko
force-pushed
the
feat/add_push_certificate_otel
branch
from
March 24, 2023 11:11
b521790
to
5aa9ac5
Compare
Freyskeyd
reviewed
Mar 24, 2023
crates/topos-sequencer-subnet-runtime-proxy/src/subnet_runtime_proxy.rs
Outdated
Show resolved
Hide resolved
crates/topos-sequencer-subnet-runtime-proxy/src/subnet_runtime_proxy.rs
Outdated
Show resolved
Hide resolved
crates/topos-sequencer-subnet-runtime-proxy/src/subnet_runtime_proxy.rs
Outdated
Show resolved
Hide resolved
atanmarko
force-pushed
the
feat/add_push_certificate_otel
branch
from
March 28, 2023 08:11
5aa9ac5
to
525f437
Compare
atanmarko
force-pushed
the
feat/add_push_certificate_otel
branch
from
March 28, 2023 09:05
525f437
to
8486004
Compare
hadjiszs
approved these changes
Mar 28, 2023
@Freyskeyd This is how it currently looks like with latest change: |
Freyskeyd
approved these changes
Mar 28, 2023
crates/topos-sequencer-subnet-runtime-proxy/src/subnet_runtime_proxy.rs
Outdated
Show resolved
Hide resolved
atanmarko
force-pushed
the
feat/add_push_certificate_otel
branch
from
March 28, 2023 13:03
0f97806
to
856bfb7
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add instrumentation event
PushCertificate
, to mark the submit of the certificate from sequencer to target subnet smart contract.Fixes TP-327
PR Checklist: