Skip to content
This repository has been archived by the owner on Oct 31, 2024. It is now read-only.

feat: add push certificate instrumentation event #195

Merged
merged 5 commits into from
Mar 28, 2023

Conversation

atanmarko
Copy link
Member

@atanmarko atanmarko commented Mar 24, 2023

Description

Add instrumentation event PushCertificate, to mark the submit of the certificate from sequencer to target subnet smart contract.

Fixes TP-327

PR Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added or updated tests that comprehensively prove my change is effective or that my feature works

@atanmarko atanmarko requested a review from a team as a code owner March 24, 2023 11:08
@atanmarko atanmarko requested a review from Freyskeyd March 24, 2023 11:08
@atanmarko atanmarko self-assigned this Mar 24, 2023
@atanmarko atanmarko requested a review from JDawg287 March 24, 2023 11:08
@atanmarko atanmarko force-pushed the feat/add_push_certificate_otel branch from b521790 to 5aa9ac5 Compare March 24, 2023 11:11
@atanmarko atanmarko force-pushed the feat/add_push_certificate_otel branch from 5aa9ac5 to 525f437 Compare March 28, 2023 08:11
@atanmarko atanmarko changed the base branch from main to fix/TP-527 March 28, 2023 08:11
Base automatically changed from fix/TP-527 to main March 28, 2023 09:04
@atanmarko atanmarko force-pushed the feat/add_push_certificate_otel branch from 525f437 to 8486004 Compare March 28, 2023 09:05
crates/topos-sequencer/src/app_context.rs Outdated Show resolved Hide resolved
@atanmarko
Copy link
Member Author

atanmarko commented Mar 28, 2023

@Freyskeyd This is how it currently looks like with latest change:
image

@atanmarko atanmarko force-pushed the feat/add_push_certificate_otel branch from 0f97806 to 856bfb7 Compare March 28, 2023 13:03
@atanmarko atanmarko merged commit 865d375 into main Mar 28, 2023
@atanmarko atanmarko deleted the feat/add_push_certificate_otel branch March 28, 2023 14:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants