Skip to content
This repository has been archived by the owner on Oct 31, 2024. It is now read-only.

feat: get pending certificates #200

Merged
merged 7 commits into from
Apr 3, 2023
Merged

feat: get pending certificates #200

merged 7 commits into from
Apr 3, 2023

Conversation

atanmarko
Copy link
Member

@atanmarko atanmarko commented Mar 28, 2023 •
edited
Loading

Description

Add tce api function GetLastPendingCertificates to retrieve latest generated pending certificate for list of subnet ids.
Sequencer on restart now continues generating certificates from latest previously generated and pushed certificate to the TCE

Fixes TP-508

Additions and Changes

Add api function primarily for sequencer to determine latest certificate it produced so that it could continue generating certificates from that point.
Updated tce storage api to implement this functinality.

Breaking changes

TCE GRPC api is changed, client needs to be rebuilt.

PR Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added or updated tests that comprehensively prove my change is effective or that my feature works

@atanmarko atanmarko self-assigned this Mar 28, 2023
@atanmarko atanmarko marked this pull request as ready for review March 29, 2023 14:17
@atanmarko atanmarko requested a review from a team as a code owner March 29, 2023 14:17
Freyskeyd
Freyskeyd suggested changes Mar 30, 2023
View reviewed changes
crates/topos-api/proto/topos/tce/v1/api.proto Outdated Show resolved Hide resolved
crates/topos-api/tests/tce_layer.rs Show resolved Hide resolved
crates/topos-api/tests/tce_layer.rs Show resolved Hide resolved
crates/topos-sequencer-tce-proxy/src/lib.rs Outdated Show resolved Hide resolved
crates/topos-sequencer-tce-proxy/src/lib.rs Outdated Show resolved Hide resolved
crates/topos-tce-api/src/grpc/mod.rs Outdated Show resolved Hide resolved
crates/topos-tce-api/src/runtime/events.rs Outdated Show resolved Hide resolved
crates/topos-tce-storage/src/client.rs Show resolved Hide resolved
crates/topos-tce-storage/src/connection/handlers.rs Outdated Show resolved Hide resolved
crates/topos-tce/src/app_context.rs Outdated Show resolved Hide resolved
@atanmarko atanmarko requested a review from Freyskeyd March 31, 2023 10:27
hadjiszs
hadjiszs reviewed Apr 3, 2023
View reviewed changes
crates/topos-api/src/generated/topos.tce.v1.rs Show resolved Hide resolved
crates/topos-api/src/generated/topos.tce.v1.rs Show resolved Hide resolved
crates/topos-sequencer-tce-proxy/Cargo.toml Outdated Show resolved Hide resolved
crates/topos-sequencer-tce-proxy/src/lib.rs Outdated Show resolved Hide resolved
crates/topos-sequencer-tce-proxy/src/lib.rs Outdated Show resolved Hide resolved
crates/topos-sequencer-tce-proxy/tests/tce_tests.rs Outdated Show resolved Hide resolved
crates/topos-tce-storage/src/tests/mod.rs Outdated Show resolved Hide resolved
crates/topos-tce/src/app_context.rs Show resolved Hide resolved
Freyskeyd
Freyskeyd approved these changes Apr 3, 2023
View reviewed changes
crates/topos-api/proto/topos/tce/v1/api.proto Outdated Show resolved Hide resolved
crates/topos-sequencer-tce-proxy/Cargo.toml Outdated Show resolved Hide resolved
crates/topos-tce-storage/src/connection/handlers.rs Show resolved Hide resolved
crates/topos-tce-api/src/grpc/mod.rs Outdated Show resolved Hide resolved
@topos-protocol topos-protocol deleted a comment from Freyskeyd Apr 3, 2023
@hadjiszs hadjiszs self-requested a review April 3, 2023 14:36
@atanmarko atanmarko merged commit fb7516e into main Apr 3, 2023
@atanmarko atanmarko deleted the feat/TP-508 branch April 3, 2023 14:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Freyskeyd Freyskeyd Freyskeyd approved these changes

@hadjiszs hadjiszs hadjiszs approved these changes

@JDawg287 JDawg287 Awaiting requested review from JDawg287 JDawg287 is a code owner automatically assigned from topos-protocol/protocol

Assignees

@atanmarko atanmarko

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@atanmarko @Freyskeyd @hadjiszs