Skip to content
This repository has been archived by the owner on Oct 31, 2024. It is now read-only.

feat: run polygon edge from topos cli #220

Merged
merged 2 commits into from
Apr 28, 2023
Merged

feat: run polygon edge from topos cli #220

merged 2 commits into from
Apr 28, 2023

Conversation

atanmarko
Copy link
Member

Description

Add additional topos cli command subnet run which runs Polygon Edge node as a subprocess

Fixes TP-408

Additions and Changes

Polygon Edge sub-process inherits standard input and output from topos cli process. When executed, to shut it down press ctrl+C

Run Polygon Edge

Usage: topos subnet run [OPTIONS] [POLYGON_EDGE_ARGUMENTS]...

Arguments:
  [POLYGON_EDGE_ARGUMENTS]...  Command line to start child process

Options:
      --path <PATH>  Installation directory path for Polygon Edge binary. If not provided, Polygon Edge binary will be expected in the current directory [env: TOPOS_SUBNET_PATH=] [default: .]
  -v, --verbose...   Defines the verbosity level
  -h, --help         Print help

For example to print Polygon Edge options, execute:

topos subnet run -- --help

PR Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added or updated tests that comprehensively prove my change is effective or that my feature works

@atanmarko atanmarko self-assigned this Apr 26, 2023
@atanmarko atanmarko requested a review from a team as a code owner April 26, 2023 11:36
@atanmarko atanmarko requested review from gruberb, JDawg287 and hadjiszs and removed request for a team April 26, 2023 11:36
Copy link
Contributor

@gruberb gruberb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

I left a comment about missing doc-comments. It might seem nit-picky, so just wanted to check how strict we are about it!

@atanmarko
Copy link
Member Author

LGTM +1

I left a comment about missing doc-comments. It might seem nit-picky, so just wanted to check how strict we are about it!

Maybe we lost a discipline a bit as we as a team are working on a same codebase for long so every note/suggestion is welcome.

crates/topos/src/components/subnet/commands/subnet.rs Outdated Show resolved Hide resolved
crates/topos/src/components/sequencer/commands.rs Outdated Show resolved Hide resolved
crates/topos/src/components/setup/commands.rs Outdated Show resolved Hide resolved
crates/topos/src/components/subnet/commands.rs Outdated Show resolved Hide resolved
crates/topos/src/components/tce/commands.rs Outdated Show resolved Hide resolved
crates/topos/src/components/network/commands.rs Outdated Show resolved Hide resolved
crates/topos/src/components/subnet/commands/subnet.rs Outdated Show resolved Hide resolved
crates/topos/src/components/subnet/mod.rs Outdated Show resolved Hide resolved
Base automatically changed from feat/TP-495 to main April 28, 2023 10:04
@atanmarko atanmarko force-pushed the feat/TP-408 branch 2 times, most recently from 62d6211 to e86447d Compare April 28, 2023 10:24
@atanmarko atanmarko merged commit 4b27fe6 into main Apr 28, 2023
@atanmarko atanmarko deleted the feat/TP-408 branch April 28, 2023 10:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants