This repository has been archived by the owner on Oct 31, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1da4cea
to
5e5b9fb
Compare
5e5b9fb
to
c1c1083
Compare
Codecov Report
@@ Coverage Diff @@
## main #234 +/- ##
==========================================
- Coverage 59.45% 59.44% -0.01%
==========================================
Files 170 170
Lines 9643 9644 +1
==========================================
Hits 5733 5733
- Misses 3910 3911 +1
|
c1c1083
to
080db61
Compare
080db61
to
7b13258
Compare
7b13258
to
b8179fc
Compare
gruberb
reviewed
May 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing too major, just suggesting adding cont
s and variables instead of directly adding &str
.
gruberb
approved these changes
May 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implemented sequencer test with send tocken and certificate cration
Fixes TP-594
Additions and Changes
PR Checklist: