Skip to content
This repository has been archived by the owner on Oct 31, 2024. It is now read-only.

feat: send token sequencer test #234

Merged
merged 3 commits into from
May 18, 2023
Merged

feat: send token sequencer test #234

merged 3 commits into from
May 18, 2023

Conversation

atanmarko
Copy link
Member

@atanmarko atanmarko commented May 15, 2023

Description

Implemented sequencer test with send tocken and certificate cration

Fixes TP-594

Additions and Changes

PR Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added or updated tests that comprehensively prove my change is effective or that my feature works

@atanmarko atanmarko self-assigned this May 15, 2023
@atanmarko atanmarko force-pushed the feat/send-token-test branch from 1da4cea to 5e5b9fb Compare May 16, 2023 09:13
Base automatically changed from feat/TP-594 to main May 16, 2023 10:21
@atanmarko atanmarko force-pushed the feat/send-token-test branch from 5e5b9fb to c1c1083 Compare May 16, 2023 10:22
@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Merging #234 (0975f0b) into main (789b803) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #234      +/-   ##
==========================================
- Coverage   59.45%   59.44%   -0.01%     
==========================================
  Files         170      170              
  Lines        9643     9644       +1     
==========================================
  Hits         5733     5733              
- Misses       3910     3911       +1     
Impacted Files Coverage Δ
crates/topos-sequencer-subnet-client/src/lib.rs 0.40% <0.00%> (ø)
...pos-sequencer-subnet-client/src/subnet_contract.rs 0.00% <0.00%> (ø)

@atanmarko atanmarko force-pushed the feat/send-token-test branch from c1c1083 to 080db61 Compare May 16, 2023 12:56
@atanmarko atanmarko marked this pull request as ready for review May 16, 2023 12:56
@atanmarko atanmarko requested a review from a team as a code owner May 16, 2023 12:56
@atanmarko atanmarko requested review from Freyskeyd and gruberb May 16, 2023 12:56
@atanmarko atanmarko force-pushed the feat/send-token-test branch from 080db61 to 7b13258 Compare May 16, 2023 13:11
@atanmarko atanmarko force-pushed the feat/send-token-test branch from 7b13258 to b8179fc Compare May 16, 2023 13:13
@atanmarko atanmarko requested a review from hadjiszs May 16, 2023 14:07
Copy link
Contributor

@gruberb gruberb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing too major, just suggesting adding conts and variables instead of directly adding &str.

crates/topos-sequencer-subnet-client/src/lib.rs Outdated Show resolved Hide resolved
@atanmarko atanmarko requested a review from gruberb May 18, 2023 07:05
Copy link
Contributor

@gruberb gruberb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@atanmarko atanmarko merged commit 31904de into main May 18, 2023
@atanmarko atanmarko deleted the feat/send-token-test branch May 18, 2023 09:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants