Skip to content
This repository has been archived by the owner on Oct 31, 2024. It is now read-only.

feat: adding taskmanager and criterion benches #263

Merged
merged 13 commits into from
Jul 20, 2023
Merged

feat: adding taskmanager and criterion benches #263

merged 13 commits into from
Jul 20, 2023

Conversation

gruberb
Copy link
Contributor

@gruberb gruberb commented Jul 13, 2023

Description

Very early draft PR. Testing can be done via:

cargo test -p topos-tce-broadcast task_manager_channels_receiving_messages
cargo test -p topos-tce-broadcast task_manager_futures_receiving_messages

Benchmarking the task manager:

cargo bench -p topos-tce-broadcast --bench double_echo

Fixes TP-639

Additions and Changes

Please explain in detail, if applicable, which changes you performed in the PR and link them to issues. (If not applicable you can remove this whole section)

Bug fix (non-breaking change which fixes an issue)

New feature (non-breaking change which adds functionality)

Breaking changes

Please explain in detail which changes are breaking changes in the PR. (If not applicable you can remove this whole section)

PR Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added or updated tests that comprehensively prove my change is effective or that my feature works

@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Merging #263 (1faf49c) into main (2fc1d9e) will increase coverage by 0.39%.
The diff coverage is 90.00%.

@@            Coverage Diff             @@
##             main     #263      +/-   ##
==========================================
+ Coverage   53.08%   53.48%   +0.39%     
==========================================
  Files         203      206       +3     
  Lines        9978    10087     +109     
==========================================
+ Hits         5297     5395      +98     
- Misses       4681     4692      +11     
Impacted Files Coverage Δ
crates/topos-tce-broadcast/src/lib.rs 88.76% <ø> (-0.13%) ⬇️
crates/topos-tce-broadcast/src/tests/mod.rs 97.89% <ø> (ø)
...os-tce-broadcast/src/task_manager_channels/task.rs 79.66% <79.66%> (ø)
...opos-tce-broadcast/src/task_manager_futures/mod.rs 91.66% <91.66%> (ø)
...pos-tce-broadcast/src/task_manager_futures/task.rs 96.55% <96.55%> (ø)
...pos-tce-broadcast/src/task_manager_channels/mod.rs 100.00% <100.00%> (ø)
...s-tce-broadcast/src/tests/task_manager_channels.rs 100.00% <100.00%> (ø)
...os-tce-broadcast/src/tests/task_manager_futures.rs 100.00% <100.00%> (ø)

... and 34 files with indirect coverage changes

@gruberb gruberb marked this pull request as ready for review July 20, 2023 07:10
@gruberb gruberb requested a review from a team as a code owner July 20, 2023 07:10
@gruberb gruberb requested review from Freyskeyd and JDawg287 July 20, 2023 07:10
@gruberb gruberb merged commit 83293b1 into main Jul 20, 2023
@gruberb gruberb deleted the feat/TP-639 branch July 20, 2023 13:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants