Skip to content
This repository has been archived by the owner on Oct 31, 2024. It is now read-only.

chore: remove unused telemetry #264

Merged
merged 1 commit into from
Jul 21, 2023
Merged

Conversation

Freyskeyd
Copy link
Member

Description

Remove unused telemetry spans and setup after the refactor and the switch to prometheus to track delivery

PR Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added or updated tests that comprehensively prove my change is effective or that my feature works

Sorry, something went wrong.

Signed-off-by: Simon Paitrault <simon.paitrault@gmail.com>
@Freyskeyd Freyskeyd requested a review from a team as a code owner July 21, 2023 08:10
@Freyskeyd Freyskeyd requested review from gruberb and JDawg287 July 21, 2023 08:10
@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Merging #264 (d2657a4) into main (83293b1) will decrease coverage by 0.47%.
The diff coverage is 66.07%.

@@            Coverage Diff             @@
##             main     #264      +/-   ##
==========================================
- Coverage   53.48%   53.01%   -0.47%     
==========================================
  Files         206      205       -1     
  Lines       10087     9934     -153     
==========================================
- Hits         5395     5267     -128     
+ Misses       4692     4667      -25     
Impacted Files Coverage Δ
crates/topos-tce-api/src/grpc/mod.rs 57.00% <ø> (-3.00%) ⬇️
crates/topos-tce-api/src/runtime/commands.rs 0.00% <ø> (ø)
crates/topos-tce-api/src/runtime/mod.rs 63.27% <ø> (-1.11%) ⬇️
crates/topos-tce-broadcast/src/lib.rs 88.63% <ø> (-0.13%) ⬇️
crates/topos-tce-broadcast/src/tests/mod.rs 97.89% <ø> (ø)
...s-tce-broadcast/src/tests/task_manager_channels.rs 100.00% <ø> (ø)
...os-tce-broadcast/src/tests/task_manager_futures.rs 100.00% <ø> (ø)
crates/topos-tce-transport/src/lib.rs 66.66% <ø> (ø)
crates/topos-tce/src/app_context/api.rs 58.24% <ø> (-1.34%) ⬇️
crates/topos-tce-broadcast/src/double_echo/mod.rs 72.60% <58.69%> (-0.15%) ⬇️
... and 3 more

... and 1 file with indirect coverage changes

Copy link
Contributor

@gruberb gruberb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Freyskeyd Freyskeyd merged commit a59b773 into main Jul 21, 2023
@Freyskeyd Freyskeyd deleted the chore/remove-unused-telemetry branch July 21, 2023 09:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants