Skip to content
This repository has been archived by the owner on Oct 31, 2024. It is now read-only.

fix: switch to safe grpc conversion for cert #309

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

Freyskeyd
Copy link
Member

Description

In order to avoid panicking when malformed certificates are pushed or failure during parsing.

PR Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added or updated tests that comprehensively prove my change is effective or that my feature works

Signed-off-by: Simon Paitrault <simon.paitrault@gmail.com>
@Freyskeyd Freyskeyd requested a review from a team as a code owner September 22, 2023 08:41
@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01% 🎉

Comparison is base (2b7517c) 57.64% compared to head (cc2691e) 57.65%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #309      +/-   ##
==========================================
+ Coverage   57.64%   57.65%   +0.01%     
==========================================
  Files         228      228              
  Lines       11807    11801       -6     
==========================================
- Hits         6806     6804       -2     
+ Misses       5001     4997       -4     
Files Changed Coverage Δ
...topos-api/src/grpc/conversions/shared/v1/subnet.rs 36.84% <ø> (ø)
...rates/topos-api/src/grpc/conversions/uci/v1/uci.rs 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Freyskeyd Freyskeyd merged commit b2d7ff6 into main Sep 22, 2023
@Freyskeyd Freyskeyd deleted the fix/safe-grpc-conversion branch September 22, 2023 09:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants